From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 10116 invoked by alias); 29 Nov 2007 15:52:25 -0000 Received: (qmail 10108 invoked by uid 22791); 29 Nov 2007 15:52:25 -0000 X-Spam-Status: No, hits=-2.5 required=5.0 tests=AWL,BAYES_00,DK_POLICY_SIGNSOME,FORGED_RCVD_HELO,SPF_HELO_PASS,SPF_PASS X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (66.187.233.31) by sourceware.org (qpsmtpd/0.31) with ESMTP; Thu, 29 Nov 2007 15:52:21 +0000 Received: from int-mx1.corp.redhat.com (int-mx1.corp.redhat.com [172.16.52.254]) by mx1.redhat.com (8.13.8/8.13.1) with ESMTP id lATFqIER010099; Thu, 29 Nov 2007 10:52:18 -0500 Received: from pobox-2.corp.redhat.com (pobox-2.corp.redhat.com [10.11.255.15]) by int-mx1.corp.redhat.com (8.13.1/8.13.1) with ESMTP id lATFqIRH016018; Thu, 29 Nov 2007 10:52:18 -0500 Received: from localhost.localdomain (dhcp-170.hsv.redhat.com [172.16.17.170]) by pobox-2.corp.redhat.com (8.13.1/8.13.1) with ESMTP id lATFqH3J005581; Thu, 29 Nov 2007 10:52:18 -0500 Message-ID: <474EE031.800@redhat.com> Date: Thu, 29 Nov 2007 15:52:00 -0000 From: David Smith User-Agent: Thunderbird 2.0.0.9 (X11/20071115) MIME-Version: 1.0 To: David Wilder CC: SystemTAP Subject: Re: Results of systemtap-20071124 snapshot on s390x References: <474B661C.9040203@us.ibm.com> <474C2B4C.4020708@redhat.com> <474C9498.6000701@us.ibm.com> <474C9B88.7030104@redhat.com> <474CA321.7020905@us.ibm.com> <474D8447.3080705@redhat.com> In-Reply-To: <474D8447.3080705@redhat.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit X-IsSubscribed: yes Mailing-List: contact systemtap-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Post: List-Help: , Sender: systemtap-owner@sourceware.org X-SW-Source: 2007-q4/txt/msg00415.txt.bz2 David Smith wrote: > David Wilder wrote: > > Interesting. The problem isn't that the marker the test used didn't > have an argument. Otherwise, you would have gotten an error that looked > like the error message you got above (that comes from K_MARKER05). For > instance, here's what I get when I try to compile a probe that uses > '$arg1' when a marker doesn't have any arguments. > > # stap -e 'probe kernel.mark("mm_handle_fault_exit") { print($arg1)}' > semantic error: invalid marker argument number: identifier '$arg1' > at :1:51 while resolving probe point > kernel.mark("mm_handle_fault_exit") > Pass 2: analysis failed. Try again with more '-v' (verbose) options. > > What's weird is that only K_MARKER04 is failing. K_MARKER01 and > K_MARKER02 compile correctly, yet K_MARKER04 doesn't compile. The only > difference between K_MARKER02 and K_MARKER04 is that K_MARKER04 prints > $arg1. I may have just found and fixed this. In updating the marker test, I started receiving a similar failure (on x86). After debugging this a bit, I found that it was because the marker had more than one string argument - the translator was emitting invalid code in this case. I've fixed this now. -- David Smith dsmith@redhat.com Red Hat http://www.redhat.com 256.217.0141 (direct) 256.837.0057 (fax)