Re: Version 0.6.1 systemtap for Fedora 8 and available for testing

[William Cohen <wcohen@redhat.com>]

[-- Attachment #1: Type: text/plain, Size: 1275 bytes --]

Steve Dickson wrote:
> Hey Will,
> 
> William Cohen wrote:
>> Hi All,
>>
>> There is a newer version of systemtap, 0.6.1-1.fc8, built for Fedora 8.
>> It is currently available for testing. With some feedback of successful
>> testing it
>> will be moved to fedora 8 stable updates. The fedora systemtap testing
>> rpms can be obtained from via yum with either of the following commands:
> I'm getting the the following syntax error with systemtap, 0.6.1-1.fc9
> on the latest rawhide kernel (2.6.24-3):
> 
> /usr/share/systemtap/runtime/stack-i386.c:26:22: error: #if with no expression
> In file included from /usr/share/systemtap/runtime/stack.c:34,
>                  from /tmp/stapkrsLQD/stap_b2ef1e50aab83af35ff4ac429676aa44_12262.c:44:
> /usr/share/systemtap/runtime/stack-i386.c: In function '__stp_stack_print':
> /usr/share/systemtap/runtime/stack-i386.c:30: error: 'ebp' undeclared (first use in this function)
> /usr/share/systemtap/runtime/stack-i386.c:30: error: (Each undeclared identifier is reported only once
> /usr/share/systemtap/runtime/stack-i386.c:30: error: for each function it appears in.)
> 
> steved.


That problem has been fixed in the cvs repostitory recently. The attached patch 
shows what needs to be fixed up. To correct the problem.

-Will

[-- Attachment #2: stack-i386_else.diff --]
[-- Type: text/x-patch, Size: 1082 bytes --]

? testsuite/systemtap.syscall/hidden
Index: runtime/ChangeLog
===================================================================
RCS file: /cvs/systemtap/src/runtime/ChangeLog,v
retrieving revision 1.237
retrieving revision 1.238
diff -U2 -u -r1.237 -r1.238
--- runtime/ChangeLog	15 Jan 2008 16:57:20 -0000	1.237
+++ runtime/ChangeLog	27 Jan 2008 18:27:40 -0000	1.238
@@ -1,2 +1,6 @@
+2008-01-27  Frank Ch. Eigler  <fche@elastic.org>
+
+	* stack-i386.c (__stp_stack_print): Correct #elif->#else typo.
+
 2008-01-14  Martin Hunt  <hunt@redhat.com>
 
Index: runtime/stack-i386.c
===================================================================
RCS file: /cvs/systemtap/src/runtime/stack-i386.c,v
retrieving revision 1.6
retrieving revision 1.7
diff -U2 -u -r1.6 -r1.7
--- runtime/stack-i386.c	18 Jan 2008 08:47:31 -0000	1.6
+++ runtime/stack-i386.c	27 Jan 2008 18:27:40 -0000	1.7
@@ -24,5 +24,5 @@
                 #ifdef STAPCONF_X86_UNIREGS
                 unsigned long ebp = regs->bp;
-                #elif
+                #else
 		unsigned long ebp = regs->ebp;
 		#endif