From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 5781 invoked by alias); 31 Jan 2008 20:32:58 -0000 Received: (qmail 5745 invoked by uid 22791); 31 Jan 2008 20:32:57 -0000 X-Spam-Status: No, hits=-2.5 required=5.0 tests=AWL,BAYES_00,SPF_HELO_PASS,SPF_PASS X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (66.187.233.31) by sourceware.org (qpsmtpd/0.31) with ESMTP; Thu, 31 Jan 2008 20:32:40 +0000 Received: from int-mx1.corp.redhat.com (int-mx1.corp.redhat.com [172.16.52.254]) by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id m0VKWceG013839 for ; Thu, 31 Jan 2008 15:32:38 -0500 Received: from lacrosse.corp.redhat.com (lacrosse.corp.redhat.com [172.16.52.154]) by int-mx1.corp.redhat.com (8.13.1/8.13.1) with ESMTP id m0VKWbZr019570; Thu, 31 Jan 2008 15:32:37 -0500 Received: from dhcp231-154.rdu.redhat.com (dhcp231-154.rdu.redhat.com [10.11.231.154]) by lacrosse.corp.redhat.com (8.12.11.20060308/8.11.6) with ESMTP id m0VKWb0O001466; Thu, 31 Jan 2008 15:32:37 -0500 Message-ID: <47A23064.7060204@redhat.com> Date: Thu, 31 Jan 2008 20:32:00 -0000 From: William Cohen User-Agent: Thunderbird 2.0.0.9 (X11/20071115) MIME-Version: 1.0 To: Masami Hiramatsu CC: systemtap Subject: Re: Adding provide to systemtap.spec for systemtap-testsuite rpm References: <47A1DABC.7020903@redhat.com> <47A1FFB0.9070901@redhat.com> In-Reply-To: <47A1FFB0.9070901@redhat.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-Scanned-By: MIMEDefang 2.58 on 172.16.52.254 X-IsSubscribed: yes Mailing-List: contact systemtap-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Post: List-Help: , Sender: systemtap-owner@sourceware.org X-SW-Source: 2008-q1/txt/msg00190.txt.bz2 Masami Hiramatsu wrote: > Hi, > > William Cohen wrote: >> Some people may notice that systemtap-testsuite rpm does not install without >> "--nodeps" because systemtaptestsuite requires "stap", but nothing provides it. >> The one line patch add a provides to the systemtap rpm and allows the >> systemtap-testsuite rpm to be installed normally via rpm. > > Instead of that, how about adding stap filtering rule to __find_requires macro? Hi Masami, What would be the advantage of changing the __find_requires macro? Allow systemtap-test rpm to be installed by developers doing testing of locally built systemtap without needing the systemtap rpm? >> Any comments about the patch? Go ahead and check it in? Or does anyone have >> better ideas on how to eliminate this issue? > > I'm not completely sure why it requires 'stap'. When I built it, the > systemtap-testsuite package built with bundled_elfutils required stap, but > without bundled_elfutils, it did not required stap. > So, I think it is caused by a special filter defined in systemtap.spec when > bundled_elfutils is enabled. > >> -Will >> > > Thank you, I haven't seen that effect without bundled_elfutils stap was not required. However, I see that there are some lines that fiddle with the __find_provides. The rpmbuild process scans through executable files to find out which interpreters are used by various scripts. There are a number of scripts in the tests that begin with: #! stap The scanning picks out the interpreter, "stap" and makes it a dependency for systemtap-testsuite. So does it make sense to install systemtap-testsuite without systemtap? If systemtap-testsuite should be installed with systemtap, it seems like the explicit provides would be reasonable. -Will