From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 2803 invoked by alias); 3 Mar 2008 16:48:37 -0000 Received: (qmail 2795 invoked by uid 22791); 3 Mar 2008 16:48:37 -0000 X-Spam-Status: No, hits=-2.5 required=5.0 tests=AWL,BAYES_00,SPF_HELO_PASS,SPF_PASS X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (66.187.233.31) by sourceware.org (qpsmtpd/0.31) with ESMTP; Mon, 03 Mar 2008 16:48:19 +0000 Received: from int-mx1.corp.redhat.com (int-mx1.corp.redhat.com [172.16.52.254]) by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id m23GmH0a008471 for ; Mon, 3 Mar 2008 11:48:17 -0500 Received: from lacrosse.corp.redhat.com (lacrosse.corp.redhat.com [172.16.52.154]) by int-mx1.corp.redhat.com (8.13.1/8.13.1) with ESMTP id m23GmH5K005539; Mon, 3 Mar 2008 11:48:17 -0500 Received: from localhost.localdomain (dhcp231-154.rdu.redhat.com [10.11.231.154]) by lacrosse.corp.redhat.com (8.12.11.20060308/8.11.6) with ESMTP id m23Gm6uR028987; Mon, 3 Mar 2008 11:48:06 -0500 Message-ID: <47CC2BCD.7080508@redhat.com> Date: Mon, 03 Mar 2008 16:48:00 -0000 From: William Cohen User-Agent: Thunderbird 2.0.0.12 (X11/20080226) MIME-Version: 1.0 To: "Frank Ch. Eigler" CC: Ananth N Mavinakayanahalli , srinivasa@in.ibm.com, systemtap@sources.redhat.com Subject: Re: changelog files, %( %) idioms References: <20080225145915.GA8718@redhat.com> <20080303121841.GA18212@in.ibm.com> <20080303162251.GA23898@redhat.com> In-Reply-To: <20080303162251.GA23898@redhat.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-Scanned-By: MIMEDefang 2.58 on 172.16.52.254 X-IsSubscribed: yes Mailing-List: contact systemtap-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Post: List-Help: , Sender: systemtap-owner@sourceware.org X-SW-Source: 2008-q1/txt/msg00344.txt.bz2 Frank Ch. Eigler wrote: > Hi - > > On Mon, Mar 03, 2008 at 05:48:41PM +0530, Ananth N Mavinakayanahalli wrote: >> [...] >> probe syscall.sigaltstack = kernel.function("sys_sigaltstack") { >> name = "sigaltstack" >> - ebx = $ebx >> - argstr = sprintf("%p", $ebx) >> + bx = %( kernel_vr > "2.6.24" %? $bx %: $ebx %) >> + argstr = sprintf("%p", %( kernel_vr > "2.6.24" %? $bx %: $ebx %) ) > > I suggest picking a single more informative variable name than "ebx" > or "bx" for that parameter. Then that variable could be used as the > plain sprintf value. > > - FChE I saw this this cause failure on F-9 i686. There could be 2.6.24.1, so probably want to check that the kernel is earlier than 2.6.25. Something like the following: bx = %( kernel_vr < "2.6.25" %? $bx %: $ebx %) Could the use of $bx be factored out of argstr, so there is only one check for the kernel version for $ebx/$bx rather than two? -Will