From: Lai Jiangshan <laijs@cn.fujitsu.com>
To: KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
Greg KH <gregkh@suse.de>,
stable@kernel.org,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Mathieu Desnoyers <mathieu.desnoyers@polymtl.ca>,
Roland McGrath <roland@redhat.com>,
Wenji Huang <wenji.huang@oracle.com>,
Takashi Nishiie <t-nishiie@np.css.fujitsu.com>,
systemtap@sourceware.org
Subject: Re: [PATCH] markers: fix missing modpost entry in Module.markers
Date: Tue, 07 Oct 2008 10:11:00 -0000 [thread overview]
Message-ID: <48EB3542.2060306@cn.fujitsu.com> (raw)
In-Reply-To: <20081007154401.5A59.KOSAKI.MOTOHIRO@jp.fujitsu.com>
KOSAKI Motohiro wrote:
> Hi Lai
>
> Have you seen "Markers in (non-module) kernel code?" thread?
> I think this patch and that patch treat the same issue.
>
I didn't notice that thread.
> In addition, I think mathieu's patch is better.
I greed with you, Mathieu's patch is better.
Thanks.
> So, Could I hear your opinition for that?
>
>
>> commit d35cb360c29956510b2fe1a953bd4968536f7216 brought a bug.
>> marker points compiled in vmlinux are missing in Module.markers.
>>
>> # cat Module.markers
>> subsystem_event samples/markers/marker-example integer %d string %s
>> subsystem_eventb samples/markers/marker-example
>>
>> # stap -e 'probe kernel.mark("core_marker_format"){} '
>> semantic error: no match while resolving probe point kernel.mark("core_marker_format")
>> semantic error: no probes found
>> Pass 2: analysis failed. Try again with more '-v' (verbose) options.
>>
>> This patch revert a part of d35cb360c29956510b2fe1a953bd4968536f7216.
>> Other parts have fixed duplicate modpost entry bug.
>>
>>
>> Signed-off-by: Lai Jiangshan <laijs@cn.fujitsu.com>
>> ---
>> diff --git a/scripts/mod/modpost.c b/scripts/mod/modpost.c
>> index 418cd7d..3509142 100644
>> --- a/scripts/mod/modpost.c
>> +++ b/scripts/mod/modpost.c
>> @@ -1992,8 +1992,7 @@ static void read_markers(const char *fname)
>> mod->skip = 1;
>> }
>>
>> - if (!mod->skip)
>> - add_marker(mod, marker, fmt);
>> + add_marker(mod, marker, fmt);
>> }
>> return;
>> fail:
>>
>>
>> --
>> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
>> the body of a message to majordomo@vger.kernel.org
>> More majordomo info at http://vger.kernel.org/majordomo-info.html
>> Please read the FAQ at http://www.tux.org/lkml/
>
>
>
>
>
>
next prev parent reply other threads:[~2008-10-07 10:11 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-10-07 6:38 Lai Jiangshan
2008-10-07 6:52 ` KOSAKI Motohiro
2008-10-07 10:11 ` Lai Jiangshan [this message]
2008-10-07 15:11 ` Mathieu Desnoyers
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=48EB3542.2060306@cn.fujitsu.com \
--to=laijs@cn.fujitsu.com \
--cc=akpm@linux-foundation.org \
--cc=gregkh@suse.de \
--cc=kosaki.motohiro@jp.fujitsu.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mathieu.desnoyers@polymtl.ca \
--cc=roland@redhat.com \
--cc=stable@kernel.org \
--cc=systemtap@sourceware.org \
--cc=t-nishiie@np.css.fujitsu.com \
--cc=wenji.huang@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).