* [PATCH] markers: fix missing modpost entry in Module.markers
@ 2008-10-07 6:38 Lai Jiangshan
2008-10-07 6:52 ` KOSAKI Motohiro
0 siblings, 1 reply; 4+ messages in thread
From: Lai Jiangshan @ 2008-10-07 6:38 UTC (permalink / raw)
To: Andrew Morton, Greg KH
Cc: stable, Linux Kernel Mailing List, Mathieu Desnoyers,
Roland McGrath, Wenji Huang, Takashi Nishiie, systemtap
commit d35cb360c29956510b2fe1a953bd4968536f7216 brought a bug.
marker points compiled in vmlinux are missing in Module.markers.
# cat Module.markers
subsystem_event samples/markers/marker-example integer %d string %s
subsystem_eventb samples/markers/marker-example
# stap -e 'probe kernel.mark("core_marker_format"){} '
semantic error: no match while resolving probe point kernel.mark("core_marker_format")
semantic error: no probes found
Pass 2: analysis failed. Try again with more '-v' (verbose) options.
This patch revert a part of d35cb360c29956510b2fe1a953bd4968536f7216.
Other parts have fixed duplicate modpost entry bug.
Signed-off-by: Lai Jiangshan <laijs@cn.fujitsu.com>
---
diff --git a/scripts/mod/modpost.c b/scripts/mod/modpost.c
index 418cd7d..3509142 100644
--- a/scripts/mod/modpost.c
+++ b/scripts/mod/modpost.c
@@ -1992,8 +1992,7 @@ static void read_markers(const char *fname)
mod->skip = 1;
}
- if (!mod->skip)
- add_marker(mod, marker, fmt);
+ add_marker(mod, marker, fmt);
}
return;
fail:
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] markers: fix missing modpost entry in Module.markers
2008-10-07 6:38 [PATCH] markers: fix missing modpost entry in Module.markers Lai Jiangshan
@ 2008-10-07 6:52 ` KOSAKI Motohiro
2008-10-07 10:11 ` Lai Jiangshan
0 siblings, 1 reply; 4+ messages in thread
From: KOSAKI Motohiro @ 2008-10-07 6:52 UTC (permalink / raw)
To: Lai Jiangshan
Cc: kosaki.motohiro, Andrew Morton, Greg KH, stable,
Linux Kernel Mailing List, Mathieu Desnoyers, Roland McGrath,
Wenji Huang, Takashi Nishiie, systemtap
Hi Lai
Have you seen "Markers in (non-module) kernel code?" thread?
I think this patch and that patch treat the same issue.
In addition, I think mathieu's patch is better.
So, Could I hear your opinition for that?
>
> commit d35cb360c29956510b2fe1a953bd4968536f7216 brought a bug.
> marker points compiled in vmlinux are missing in Module.markers.
>
> # cat Module.markers
> subsystem_event samples/markers/marker-example integer %d string %s
> subsystem_eventb samples/markers/marker-example
>
> # stap -e 'probe kernel.mark("core_marker_format"){} '
> semantic error: no match while resolving probe point kernel.mark("core_marker_format")
> semantic error: no probes found
> Pass 2: analysis failed. Try again with more '-v' (verbose) options.
>
> This patch revert a part of d35cb360c29956510b2fe1a953bd4968536f7216.
> Other parts have fixed duplicate modpost entry bug.
>
>
> Signed-off-by: Lai Jiangshan <laijs@cn.fujitsu.com>
> ---
> diff --git a/scripts/mod/modpost.c b/scripts/mod/modpost.c
> index 418cd7d..3509142 100644
> --- a/scripts/mod/modpost.c
> +++ b/scripts/mod/modpost.c
> @@ -1992,8 +1992,7 @@ static void read_markers(const char *fname)
> mod->skip = 1;
> }
>
> - if (!mod->skip)
> - add_marker(mod, marker, fmt);
> + add_marker(mod, marker, fmt);
> }
> return;
> fail:
>
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at http://www.tux.org/lkml/
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] markers: fix missing modpost entry in Module.markers
2008-10-07 6:52 ` KOSAKI Motohiro
@ 2008-10-07 10:11 ` Lai Jiangshan
2008-10-07 15:11 ` Mathieu Desnoyers
0 siblings, 1 reply; 4+ messages in thread
From: Lai Jiangshan @ 2008-10-07 10:11 UTC (permalink / raw)
To: KOSAKI Motohiro
Cc: Andrew Morton, Greg KH, stable, Linux Kernel Mailing List,
Mathieu Desnoyers, Roland McGrath, Wenji Huang, Takashi Nishiie,
systemtap
KOSAKI Motohiro wrote:
> Hi Lai
>
> Have you seen "Markers in (non-module) kernel code?" thread?
> I think this patch and that patch treat the same issue.
>
I didn't notice that thread.
> In addition, I think mathieu's patch is better.
I greed with you, Mathieu's patch is better.
Thanks.
> So, Could I hear your opinition for that?
>
>
>> commit d35cb360c29956510b2fe1a953bd4968536f7216 brought a bug.
>> marker points compiled in vmlinux are missing in Module.markers.
>>
>> # cat Module.markers
>> subsystem_event samples/markers/marker-example integer %d string %s
>> subsystem_eventb samples/markers/marker-example
>>
>> # stap -e 'probe kernel.mark("core_marker_format"){} '
>> semantic error: no match while resolving probe point kernel.mark("core_marker_format")
>> semantic error: no probes found
>> Pass 2: analysis failed. Try again with more '-v' (verbose) options.
>>
>> This patch revert a part of d35cb360c29956510b2fe1a953bd4968536f7216.
>> Other parts have fixed duplicate modpost entry bug.
>>
>>
>> Signed-off-by: Lai Jiangshan <laijs@cn.fujitsu.com>
>> ---
>> diff --git a/scripts/mod/modpost.c b/scripts/mod/modpost.c
>> index 418cd7d..3509142 100644
>> --- a/scripts/mod/modpost.c
>> +++ b/scripts/mod/modpost.c
>> @@ -1992,8 +1992,7 @@ static void read_markers(const char *fname)
>> mod->skip = 1;
>> }
>>
>> - if (!mod->skip)
>> - add_marker(mod, marker, fmt);
>> + add_marker(mod, marker, fmt);
>> }
>> return;
>> fail:
>>
>>
>> --
>> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
>> the body of a message to majordomo@vger.kernel.org
>> More majordomo info at http://vger.kernel.org/majordomo-info.html
>> Please read the FAQ at http://www.tux.org/lkml/
>
>
>
>
>
>
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] markers: fix missing modpost entry in Module.markers
2008-10-07 10:11 ` Lai Jiangshan
@ 2008-10-07 15:11 ` Mathieu Desnoyers
0 siblings, 0 replies; 4+ messages in thread
From: Mathieu Desnoyers @ 2008-10-07 15:11 UTC (permalink / raw)
To: Lai Jiangshan
Cc: KOSAKI Motohiro, Andrew Morton, Greg KH, stable,
Linux Kernel Mailing List, Roland McGrath, Wenji Huang,
Takashi Nishiie, systemtap
Hi Lai,
I tried to fix it in a way that would still not duplicate marker
entries, which is what the patch we are trying to repair was supposed to
do. The patch you propose here seems to go back to the old behavior
where we can have duplicate marker entries. I did not verify extensively
that my new patch does not duplicate marker entries though, but I tried
to follow the logic of your original patch.
Mathieu
* Lai Jiangshan (laijs@cn.fujitsu.com) wrote:
> KOSAKI Motohiro wrote:
> > Hi Lai
> >
> > Have you seen "Markers in (non-module) kernel code?" thread?
> > I think this patch and that patch treat the same issue.
> >
>
> I didn't notice that thread.
>
> > In addition, I think mathieu's patch is better.
>
> I greed with you, Mathieu's patch is better.
>
> Thanks.
>
> > So, Could I hear your opinition for that?
> >
> >
> >> commit d35cb360c29956510b2fe1a953bd4968536f7216 brought a bug.
> >> marker points compiled in vmlinux are missing in Module.markers.
> >>
> >> # cat Module.markers
> >> subsystem_event samples/markers/marker-example integer %d string %s
> >> subsystem_eventb samples/markers/marker-example
> >>
> >> # stap -e 'probe kernel.mark("core_marker_format"){} '
> >> semantic error: no match while resolving probe point kernel.mark("core_marker_format")
> >> semantic error: no probes found
> >> Pass 2: analysis failed. Try again with more '-v' (verbose) options.
> >>
> >> This patch revert a part of d35cb360c29956510b2fe1a953bd4968536f7216.
> >> Other parts have fixed duplicate modpost entry bug.
> >>
> >>
> >> Signed-off-by: Lai Jiangshan <laijs@cn.fujitsu.com>
> >> ---
> >> diff --git a/scripts/mod/modpost.c b/scripts/mod/modpost.c
> >> index 418cd7d..3509142 100644
> >> --- a/scripts/mod/modpost.c
> >> +++ b/scripts/mod/modpost.c
> >> @@ -1992,8 +1992,7 @@ static void read_markers(const char *fname)
> >> mod->skip = 1;
> >> }
> >>
> >> - if (!mod->skip)
> >> - add_marker(mod, marker, fmt);
> >> + add_marker(mod, marker, fmt);
> >> }
> >> return;
> >> fail:
> >>
> >>
> >> --
> >> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> >> the body of a message to majordomo@vger.kernel.org
> >> More majordomo info at http://vger.kernel.org/majordomo-info.html
> >> Please read the FAQ at http://www.tux.org/lkml/
> >
> >
> >
> >
> >
> >
>
>
--
Mathieu Desnoyers
OpenPGP key fingerprint: 8CD5 52C3 8E3C 4140 715F BA06 3F25 A8FE 3BAE 9A68
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2008-10-07 15:11 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2008-10-07 6:38 [PATCH] markers: fix missing modpost entry in Module.markers Lai Jiangshan
2008-10-07 6:52 ` KOSAKI Motohiro
2008-10-07 10:11 ` Lai Jiangshan
2008-10-07 15:11 ` Mathieu Desnoyers
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).