From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 2323 invoked by alias); 24 Oct 2008 16:21:31 -0000 Received: (qmail 2314 invoked by uid 22791); 24 Oct 2008 16:21:30 -0000 X-Spam-Status: No, hits=-2.1 required=5.0 tests=AWL,BAYES_00,J_CHICKENPOX_63,KAM_MX,SPF_HELO_PASS,SPF_PASS X-Spam-Check-By: sourceware.org Received: from mx2.redhat.com (HELO mx2.redhat.com) (66.187.237.31) by sourceware.org (qpsmtpd/0.31) with ESMTP; Fri, 24 Oct 2008 16:20:55 +0000 Received: from int-mx2.corp.redhat.com (int-mx2.corp.redhat.com [172.16.27.26]) by mx2.redhat.com (8.13.8/8.13.8) with ESMTP id m9OGKrZh013108; Fri, 24 Oct 2008 12:20:53 -0400 Received: from ns3.rdu.redhat.com (ns3.rdu.redhat.com [10.11.255.199]) by int-mx2.corp.redhat.com (8.13.1/8.13.1) with ESMTP id m9OGKraD022284; Fri, 24 Oct 2008 12:20:53 -0400 Received: from localhost.localdomain (vpn-14-40.rdu.redhat.com [10.11.14.40]) by ns3.rdu.redhat.com (8.13.8/8.13.8) with ESMTP id m9OGKq4s013406; Fri, 24 Oct 2008 12:20:52 -0400 Message-ID: <4901F5E4.7030200@redhat.com> Date: Fri, 24 Oct 2008 16:21:00 -0000 From: David Smith User-Agent: Thunderbird 2.0.0.16 (X11/20080723) MIME-Version: 1.0 To: Dave Nomura CC: systemtap@sourceware.org Subject: Re: [PATCH] itrace spin lock fix References: <48FFC1D4.7000801@us.ibm.com> In-Reply-To: <48FFC1D4.7000801@us.ibm.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit X-Scanned-By: MIMEDefang 2.58 on 172.16.27.26 X-IsSubscribed: yes Mailing-List: contact systemtap-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Post: List-Help: , Sender: systemtap-owner@sourceware.org X-SW-Source: 2008-q4/txt/msg00203.txt.bz2 Dave Nomura wrote: > Back in August Frank reported a problem running the itrace test on an > x86-64 machine. This was caused by an uninitialized spin_lock and > possibly by some utrace callouts that didn't need in the spin_lock > protected regions. This patch fixes that problem. Your patch's ChangeLog is wrong. You should put the entry in src/runtime/ChangeLog, not src/ChangeLog. I ran this patch on a RHEL5 x86_64 (2.6.18-92.1.13.el5debug) machine. Systemtap couldn't compile modules without the following small patch: diff --git a/tapsets.cxx b/tapsets.cxx index bed2796..057a554 100644 --- a/tapsets.cxx +++ b/tapsets.cxx @@ -5778,6 +5778,7 @@ itrace_derived_probe_group::emit_module_decls (systemtap_\ session& s) s.op->newline(); s.op->newline() << "/* ---- itrace probes ---- */"; + s.op->newline() << "#include \"task_finder.c\""; s.op->newline() << "struct stap_itrace_probe {"; s.op->indent(1); s.op->newline() << "struct stap_task_finder_target tgt;"; With the above patch, systemtap could compile modules again. The itrace.exp test script ran (with the early exit deleted), but failed because the itrace probes never got hit. -- David Smith dsmith@redhat.com Red Hat http://www.redhat.com 256.217.0141 (direct) 256.837.0057 (fax)