Re: [SCM] systemtap: system-wide probe/trace tool branch, master, updated. release-0.7-433-g8576ea4

Re: [SCM] systemtap: system-wide probe/trace tool branch, master, updated. release-0.7-433-g8576ea4

[Mark Wielaard]

Hi Wenji,

On Mon, 2008-11-03 at 08:40 +0000, wenji@sourceware.org wrote:
> commit 8576ea4be5619d9c169cab385ac0d31174fdee41
> Author: Wenji Huang <wenji.huang@oracle.com>
> Date:   Mon Nov 3 01:58:48 2008 -0500
> 
>     Fix hung test due to workaround for PR6964.

I must say I don't really like this workaround in the testsuite for
another workaround. The test correctly points out that because of the
previous workaround -c doesn't work reliably anymore. IMHO we shouldn't
have this cascading pile of workarounds, especially not in the tests.
Please do make sure to also revert this one, when the original PR6964
workaround is reverted.

Thanks,

Mark

Re: [SCM] systemtap: system-wide probe/trace tool branch, master, updated. release-0.7-433-g8576ea4

[Wenji Huang]

Mark Wielaard wrote:
> Hi Wenji,
> 
> On Mon, 2008-11-03 at 08:40 +0000, wenji@sourceware.org wrote:
>> commit 8576ea4be5619d9c169cab385ac0d31174fdee41
>> Author: Wenji Huang <wenji.huang@oracle.com>
>> Date:   Mon Nov 3 01:58:48 2008 -0500
>>
>>     Fix hung test due to workaround for PR6964.
> 
> I must say I don't really like this workaround in the testsuite for
> another workaround. The test correctly points out that because of the
> previous workaround -c doesn't work reliably anymore. IMHO we shouldn't
> have this cascading pile of workarounds, especially not in the tests.
> Please do make sure to also revert this one, when the original PR6964
> workaround is reverted.
> 
> Thanks,
> 
> Mark
> 
Hi Mark,

I admit that current workaround is a little annoying. But we need to 
wait utrace update. In fact, "stap -c" will cause kernel panic even on 
2.6.27+latest utrace. One simplest way is to change BUG_ON to WARN_ON so 
that no kernel panic come up any more. I think the commit will be 
reverted once new utrace kernel is ready.

Regards,
Wenji