From: Wenji Huang <wenji.huang@oracle.com>
To: Srikar Dronamraju <srikar@linux.vnet.ibm.com>
Cc: systemTAP <systemtap@sources.redhat.com>
Subject: Re: [PATCH] Fix the conflicted for_each_cpu macro with 2.6.28-rc4
Date: Tue, 18 Nov 2008 05:13:00 -0000 [thread overview]
Message-ID: <49224D75.6080308@oracle.com> (raw)
In-Reply-To: <20081118043824.GA29346@linux.vnet.ibm.com>
Srikar Dronamraju wrote:
> * Wenji Huang <wenji.huang@oracle.com> [2008-11-18 09:50:07]:
>
>>>> -#ifndef for_each_cpu
>>>> -#define for_each_cpu(cpu) for_each_cpu_mask((cpu), cpu_possible_map)
>>>> +#if LINUX_VERSION_CODE >= KERNEL_VERSION(2,6,28)
>>>> +#ifndef stp_for_each_cpu
>>>> +#define stp_for_each_cpu(cpu) for_each_cpu((cpu), cpu_possible_map)
>>>> +#endif
>>>> +#else
>>>> +#ifndef stp_for_each_cpu
>>>> +#define stp_for_each_cpu(cpu) for_each_cpu_mask((cpu),
>>>> cpu_possible_map)
>>>> +#endif
>>>> #endif
>
> Why do we use for_each_cpu_mask always instead of using for_each_cpu if
> its defined. That would make the code more concise.
>
> --
> Srikar
Good point. Just worry if for_each_cpu_mask will be changed in the later
kernel in terms of defined for_each_cpu.
Regards,
Wenji
prev parent reply other threads:[~2008-11-18 5:13 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-11-14 7:13 Wenji Huang
2008-11-17 15:56 ` William Cohen
2008-11-18 1:56 ` Wenji Huang
2008-11-18 4:39 ` Srikar Dronamraju
2008-11-18 5:13 ` Wenji Huang [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=49224D75.6080308@oracle.com \
--to=wenji.huang@oracle.com \
--cc=srikar@linux.vnet.ibm.com \
--cc=systemtap@sources.redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).