From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 23877 invoked by alias); 19 Nov 2008 17:54:11 -0000 Received: (qmail 23813 invoked by uid 22791); 19 Nov 2008 17:54:09 -0000 X-Spam-Status: No, hits=-0.8 required=5.0 tests=AWL,BAYES_40,KAM_MX,SPF_HELO_PASS,SPF_PASS X-Spam-Check-By: sourceware.org Received: from mx2.redhat.com (HELO mx2.redhat.com) (66.187.237.31) by sourceware.org (qpsmtpd/0.31) with ESMTP; Wed, 19 Nov 2008 17:53:34 +0000 Received: from int-mx2.corp.redhat.com (int-mx2.corp.redhat.com [172.16.27.26]) by mx2.redhat.com (8.13.8/8.13.8) with ESMTP id mAJHrXYk017389 for ; Wed, 19 Nov 2008 12:53:33 -0500 Received: from ns3.rdu.redhat.com (ns3.rdu.redhat.com [10.11.255.199]) by int-mx2.corp.redhat.com (8.13.1/8.13.1) with ESMTP id mAJHrWHq012368; Wed, 19 Nov 2008 12:53:32 -0500 Received: from [10.16.3.219] (dhcp-100-3-219.bos.redhat.com [10.16.3.219]) by ns3.rdu.redhat.com (8.13.8/8.13.8) with ESMTP id mAJHrVQo008837; Wed, 19 Nov 2008 12:53:31 -0500 Message-ID: <49245281.40806@redhat.com> Date: Wed, 19 Nov 2008 17:54:00 -0000 From: Masami Hiramatsu User-Agent: Thunderbird 2.0.0.16 (X11/20080723) MIME-Version: 1.0 To: Eduardo Habkost CC: systemtap@sourceware.org Subject: Re: [PATCH] stp_for_each_cpu: use for_each_possible_cpu() on kernel >= 2.6.28 References: <1227103412-9128-1-git-send-email-ehabkost@redhat.com> <492425D6.1060502@redhat.com> <20081119152444.GW4481@blackpad> In-Reply-To: <20081119152444.GW4481@blackpad> X-Enigmail-Version: 0.95.7 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Scanned-By: MIMEDefang 2.58 on 172.16.27.26 X-IsSubscribed: yes Mailing-List: contact systemtap-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Post: List-Help: , Sender: systemtap-owner@sourceware.org X-SW-Source: 2008-q4/txt/msg00389.txt.bz2 Eduardo Habkost wrote: > On Wed, Nov 19, 2008 at 09:42:30AM -0500, Masami Hiramatsu wrote: >> Hi Eduardo, >> >> I think you'd better add new autoconf-foreachcpu.c for checking existence of >> for_each_cpu_possible() macro, instead of checking KERNEL_VERSION. > > Why? for_each_cpu_possible() exists since 2.6.17. The original > for_each_cpu() fix didn't use an autoconf-*.c check. Oh, in that case, it's ok for me. Thank you, -- Masami Hiramatsu Software Engineer Hitachi Computer Products (America) Inc. Software Solutions Division e-mail: mhiramat@redhat.com