From: David Smith <dsmith@redhat.com>
To: Maynard Johnson <maynardj@us.ibm.com>
Cc: systemtap@sourceware.org
Subject: Re: [PATCH] Fix compilation errors for itrace probe point
Date: Tue, 03 Mar 2009 16:00:00 -0000 [thread overview]
Message-ID: <49AD3A7F.7030205@redhat.com> (raw)
In-Reply-To: <49AC53B1.7080203@us.ibm.com>
Maynard Johnson wrote:
> Hello,
> I recently pulled down the systemtap src onto a Fedora 10 system and tried to use the itrace
> probe point. The resulting kernel module failed to compile because
the runtime/itrace.c file
> had not been updated to reflect the recent utrace interface changes.
This problem had not
> been caught because the itrace test is currently disabled (since it
fails on x86_64).
I looked at your changes a bit. In remove_usr_itrace_info(), you
probably need to ignore EALREADY (which means the DEATH callback has
already begun so there is no point in detaching).
The changes look reasonable, but with a bit more effort you should be
able to support both the original utrace interface (for systems like
RHEL5) and the new utrace interface simultaneously. The task_finder
layer does this now - look for '#ifdef UTRACE_ORIG_VERSION' sections and
look at runtime/utrace_compatibility.h. Basically you write to the new
interface and use the defines and wrappers in
runtime/utrace_compatibility.h to make the original utrace interface
look like the new interface.
It is possible you might need to add additional defines to
runtime/utrace_compatibility.h since the itrace code uses parts of
utrace that the task_finder layer doesn't use.
Let me know if you need help with this or additional information.
--
David Smith
dsmith@redhat.com
Red Hat
http://www.redhat.com
256.217.0141 (direct)
256.837.0057 (fax)
next prev parent reply other threads:[~2009-03-03 14:11 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-03-02 23:47 Maynard Johnson
2009-03-03 0:16 ` Josh Stone
2009-03-03 16:00 ` David Smith [this message]
2009-03-03 17:31 ` [PATCH] Fix compilation errors for itrace probe point - v2 Maynard Johnson
2009-03-03 20:02 ` Maynard Johnson
2009-03-03 20:13 ` Maynard Johnson
2009-03-04 10:59 ` Maynard Johnson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=49AD3A7F.7030205@redhat.com \
--to=dsmith@redhat.com \
--cc=maynardj@us.ibm.com \
--cc=systemtap@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).