From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 25718 invoked by alias); 3 Mar 2009 16:00:35 -0000 Received: (qmail 25707 invoked by uid 22791); 3 Mar 2009 16:00:33 -0000 X-SWARE-Spam-Status: No, hits=-2.6 required=5.0 tests=BAYES_00,SPF_PASS X-Spam-Check-By: sourceware.org Received: from e6.ny.us.ibm.com (HELO e6.ny.us.ibm.com) (32.97.182.146) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 03 Mar 2009 16:00:27 +0000 Received: from d01relay02.pok.ibm.com (d01relay02.pok.ibm.com [9.56.227.234]) by e6.ny.us.ibm.com (8.13.1/8.13.1) with ESMTP id n23G1SWn012785 for ; Tue, 3 Mar 2009 11:01:28 -0500 Received: from d01av02.pok.ibm.com (d01av02.pok.ibm.com [9.56.224.216]) by d01relay02.pok.ibm.com (8.13.8/8.13.8/NCO v9.2) with ESMTP id n23G0PdN193976 for ; Tue, 3 Mar 2009 11:00:25 -0500 Received: from d01av02.pok.ibm.com (loopback [127.0.0.1]) by d01av02.pok.ibm.com (8.12.11.20060308/8.13.3) with ESMTP id n23Fx8jn006385 for ; Tue, 3 Mar 2009 10:59:08 -0500 Received: from [127.0.0.1] (9-10-86-165.rchland.ibm.com [9.10.86.165]) by d01av02.pok.ibm.com (8.12.11.20060308/8.12.11) with ESMTP id n23Fx7U8006271; Tue, 3 Mar 2009 10:59:08 -0500 Message-ID: <49AD5418.5090307@us.ibm.com> Date: Tue, 03 Mar 2009 17:31:00 -0000 From: Maynard Johnson Reply-To: maynardj@us.ibm.com User-Agent: Thunderbird 2.0.0.19 (Windows/20081209) MIME-Version: 1.0 To: David Smith CC: systemtap@sourceware.org Subject: Re: [PATCH] Fix compilation errors for itrace probe point - v2 References: <49AC53B1.7080203@us.ibm.com> <49AD3A7F.7030205@redhat.com> In-Reply-To: <49AD3A7F.7030205@redhat.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-IsSubscribed: yes Mailing-List: contact systemtap-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Post: List-Help: , Sender: systemtap-owner@sourceware.org X-SW-Source: 2009-q1/txt/msg00575.txt.bz2 David Smith wrote: > Maynard Johnson wrote: >> Hello, >> I recently pulled down the systemtap src onto a Fedora 10 system and tried to use the itrace >> probe point. The resulting kernel module failed to compile because > the runtime/itrace.c file >> had not been updated to reflect the recent utrace interface changes. > This problem had not >> been caught because the itrace test is currently disabled (since it > fails on x86_64). > > I looked at your changes a bit. In remove_usr_itrace_info(), you > probably need to ignore EALREADY (which means the DEATH callback has > already begun so there is no point in detaching). > > The changes look reasonable, but with a bit more effort you should be > able to support both the original utrace interface (for systems like > RHEL5) and the new utrace interface simultaneously. The task_finder > layer does this now - look for '#ifdef UTRACE_ORIG_VERSION' sections and > look at runtime/utrace_compatibility.h. Basically you write to the new > interface and use the defines and wrappers in > runtime/utrace_compatibility.h to make the original utrace interface > look like the new interface. > > It is possible you might need to add additional defines to > runtime/utrace_compatibility.h since the itrace code uses parts of > utrace that the task_finder layer doesn't use. > > Let me know if you need help with this or additional information. Thanks for the feedback. The revised patch I'm attaching here contains two changes compared to the original: it ignores EALREADY in remove_usr_itrace_info(); and I've added a private version of 'access_process_vm' (as discussed on a separate posting thread). Other issues I will continue to work on are: - itrace test fails on x86_64 - add backward support for older utrace interface Frank had granted me write access to the SystemTap repository a few months ago, so I can commit this when I get approval. Thanks. -Maynard >