From: Masami Hiramatsu <mhiramat@redhat.com>
To: Wenji Huang <wenji.huang@oracle.com>
Cc: systemtap@sourceware.org
Subject: Re: [PATCH 2/3] Modify %M directive to support variable width.
Date: Fri, 24 Apr 2009 15:27:00 -0000 [thread overview]
Message-ID: <49F1DA88.4050709@redhat.com> (raw)
In-Reply-To: <1240593816-31164-1-git-send-email-wenji.huang@oracle.com>
Wenji Huang wrote:
> diff --git a/testsuite/systemtap.printf/memory1.stp b/testsuite/systemtap.printf/memory1.stp
> index f9cbf60..93a4edf 100644
> --- a/testsuite/systemtap.printf/memory1.stp
> +++ b/testsuite/systemtap.printf/memory1.stp
> @@ -113,6 +113,20 @@ probe syscall.open {
> success = 0;
> }
>
> + expected_16_actual = sprintf (" %x%x%x%x%x%x",
> + chrofstr(filename, 0),
> + chrofstr(filename, 1),
> + chrofstr(filename, 2),
> + chrofstr(filename, 3),
> + chrofstr(filename, 4),
> + chrofstr(filename, 5));
Hmm, these should be %02x?
Thanks,
--
Masami Hiramatsu
Software Engineer
Hitachi Computer Products (America) Inc.
Software Solutions Division
e-mail: mhiramat@redhat.com
prev parent reply other threads:[~2009-04-24 15:27 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-04-24 10:42 Wenji Huang
2009-04-24 15:27 ` Masami Hiramatsu [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=49F1DA88.4050709@redhat.com \
--to=mhiramat@redhat.com \
--cc=systemtap@sourceware.org \
--cc=wenji.huang@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).