From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 25827 invoked by alias); 29 Apr 2009 21:08:18 -0000 Received: (qmail 25805 invoked by uid 22791); 29 Apr 2009 21:08:17 -0000 X-SWARE-Spam-Status: No, hits=-2.4 required=5.0 tests=AWL,BAYES_00,SPF_PASS X-Spam-Check-By: sourceware.org Received: from e1.ny.us.ibm.com (HELO e1.ny.us.ibm.com) (32.97.182.141) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Wed, 29 Apr 2009 21:08:12 +0000 Received: from d01relay04.pok.ibm.com (d01relay04.pok.ibm.com [9.56.227.236]) by e1.ny.us.ibm.com (8.13.1/8.13.1) with ESMTP id n3TL4bjK001581 for ; Wed, 29 Apr 2009 17:04:37 -0400 Received: from d01av04.pok.ibm.com (d01av04.pok.ibm.com [9.56.224.64]) by d01relay04.pok.ibm.com (8.13.8/8.13.8/NCO v9.2) with ESMTP id n3TL882v143862 for ; Wed, 29 Apr 2009 17:08:08 -0400 Received: from d01av04.pok.ibm.com (loopback [127.0.0.1]) by d01av04.pok.ibm.com (8.12.11.20060308/8.13.3) with ESMTP id n3TL88Rn010345 for ; Wed, 29 Apr 2009 17:08:08 -0400 Received: from [127.0.0.1] (sig-9-65-156-199.mts.ibm.com [9.65.156.199]) by d01av04.pok.ibm.com (8.12.11.20060308/8.12.11) with ESMTP id n3TL86Bf010243; Wed, 29 Apr 2009 17:08:07 -0400 Message-ID: <49F8C1C0.8070208@us.ibm.com> Date: Wed, 29 Apr 2009 21:08:00 -0000 From: Maynard Johnson User-Agent: Thunderbird 2.0.0.21 (Windows/20090302) MIME-Version: 1.0 To: David Smith CC: systemtap@sourceware.org, "Frank Ch. Eigler" Subject: Re: Backward compatibility for insn probe point References: <49D3E3DF.1000108@us.ibm.com> <49F61D09.8090503@redhat.com> In-Reply-To: <49F61D09.8090503@redhat.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit X-IsSubscribed: yes Mailing-List: contact systemtap-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Post: List-Help: , Sender: systemtap-owner@sourceware.org X-SW-Source: 2009-q2/txt/msg00481.txt.bz2 David Smith wrote: > Maynard Johnson wrote: >> Frank has already made the changes in runtime/itrace.c to support >> backward compatibility with older utrace. >> I wanted to test the insn probe point on an older utrace, so I built >> and installed systemtap 0.9.5 on a ppc970 blade running RHEL 5.3. I >> ran the following simple test: >> >> # stap -c /bin/ls simple-test.stp /bin/ls -o simple-out -k -vvv >> where simple-test.stp is . . . >> =========simple-test.stp ======================== >> global instrs = 0 >> >> probe begin { >> printf("systemtap starting probe\n") >> } >> >> probe process(@1).insn { >> instrs += 1 >> } >> >> probe end { printf("systemtap ending probe\n") >> printf("itraced = %d\n", instrs) >> } >> ================================== >> >> The result of the above test is that the stap command hangs at >> "stapio:start_cmd:195 execing target_cmd /bin/ls". If I Ctl-C the >> job, it finished (i.e, I see "Pass 5: run completed ..."), but the >> output file contents indicate the insn probe was not hit (i.e., >> "itraced = 0"). >> >> Any suggestions on where to look for the problem? > > I took a look at this and fixed it. For more details, see I've not tested the fix on x86 yet, but I'm afraid the results don't look right on ppc64/RHEL 5. But test results of 0.9.7 with your patch on ppc64/F11 were good -- no regressions. I used the following simple test script: ======================================================== global instrs = 0 probe process(@1).begin { printf("pid %d begins\n", pid()) } probe process(@1).end { printf("pid %d ends\n", pid()) } probe begin { printf("systemtap starting probe\n") } probe process(@1).insn { instrs += 1 } probe end { printf("systemtap ending probe\n") printf("itraced = %d\n", instrs) } ======================================================== I invoked the script as follows: stap -c /usr/bin/whoami simple-test.stp /usr/bin/whoami -o simple-out On Fedora 11, the simple-out file showed that I had nearly 330,000 insn probe hits. On ppc64/RHEL 5.3, I had only 65 probe hits. Can you try out the above script on an x86/RHEL 5.3 system? Thanks. -Maynard > . >