public inbox for systemtap@sourceware.org
 help / color / mirror / Atom feed
From: David Smith <dsmith@redhat.com>
To: Mahesh Jagannath Salgaonkar <mahesh@linux.vnet.ibm.com>
Cc: systemtap@sources.redhat.com
Subject: Re: Plain kprobe genearation/bisect script - latest changes
Date: Tue, 05 May 2009 15:58:00 -0000	[thread overview]
Message-ID: <4A006227.4020607@redhat.com> (raw)
In-Reply-To: <49DE1122.5060806@linux.vnet.ibm.com>

Mahesh Jagannath Salgaonkar wrote:
> Mahesh Jagannath Salgaonkar wrote:
>> Hi All,
>>
>> I have implemented shell scripts that helps me to narrow down a faulty
>> probe that causes problem/crash, while debugging systemtap issues. As
>> per the discussion in weekly systemtap meeting dated 12th March 2009,
>> I am attaching these scripts (kp_bisect.tgz) that may help us in
>> identifying probes that can be a potential candidate for blacklist.
>> These scripts will help user to extract probes (probe function name)
>> from stap generated C module and test plain kprobes/kretprobes
>> allowing user to run bisect-like functionality to narrow down to a
>> single faulty probe. It does handle ".call" and ".return" probes.
>>
>> Can someone can take look at these scripts and see if these can be
>> used as a base for automating the process of testing kprobes for
>> black/white list generation? The file "README.txt" describes the steps
>> to use these scripts.
>>
>> Thanks,
>> -Mahesh.
> 
> Please find the modified scripts attached. Modified script to isolate
> good probes/bad probes and show all bad probes at the end.

Mahesh,

I finally found some time to look at this.  The nice thing about your
scripts is that they are very simple and look like they would do the job.

The one thing that the scripts I worked on does differently is that it
ends up with 3 lists instead of 2 lists:

- a "bad" list - functions that cause crashes
- a "good" list - functions that were registered correctly and the
kprobe got hit with no problems
- an "unknown" list - functions that were registered correctly, but the
function wasn't actually called (so we don't really know if a kprobe can
be safely used with that function or not)

-- 
David Smith
dsmith@redhat.com
Red Hat
http://www.redhat.com
256.217.0141 (direct)
256.837.0057 (fax)

      reply	other threads:[~2009-05-05 15:58 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-04-07  8:59 Plain kprobe genearation/bisect script Mahesh Jagannath Salgaonkar
2009-04-09 15:16 ` Plain kprobe genearation/bisect script - latest changes Mahesh Jagannath Salgaonkar
2009-05-05 15:58   ` David Smith [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4A006227.4020607@redhat.com \
    --to=dsmith@redhat.com \
    --cc=mahesh@linux.vnet.ibm.com \
    --cc=systemtap@sources.redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).