public inbox for systemtap@sourceware.org
 help / color / mirror / Atom feed
From: Malte Nuhn <nuhn@physik.rwth-aachen.de>
To: Josh Stone <jistone@redhat.com>
Cc: systemtap@sources.redhat.com
Subject: Re: context.stp - read session ID - function sid()
Date: Mon, 11 May 2009 12:21:00 -0000	[thread overview]
Message-ID: <4A081834.8080004@physik.rwth-aachen.de> (raw)
In-Reply-To: <4A0490C2.6060004@redhat.com>

Josh Stone wrote:
> On 05/08/2009 08:04 AM, Malte Nuhn wrote:
>   
>> There's basically no magic in it. I checked that the session information 
>> is stored in the "signal_struct" since Kernel version 2.6.0 - so i guess
>> it should work on every machine that is running systemtap.
>>     
>
> Unfortunately, that field is going away -- see this in the kernel:
>
>   commit 1b0f7ffd0ea27cd3a0b9ca04e3df9522048c32a3
>   Author: Oleg Nesterov <oleg@redhat.com>
>   Date:   Thu Apr 2 16:58:39 2009 -0700
>
>       pids: kill signal_struct-> __pgrp/__session and friends
>
>
> Frank already committed your patch, but can you research whether there's
> a way to let this continue to work on 2.6.30+?
>
> Thanks,
>
> Josh
>   
Oh - I'm sorry - I missed that. So here is, what I could find out:

Since commit 7af5729474b5b8ad385adadab78d6e723e7655a3, there is

static inline pid_t task_session_vnr(struct task_struct *tsk)

which i guess should do the job. There are some more wrappers for tgid, 
pgrp, and pid. Perhaps one should use them in the future.

I'm sorry, I don't have have a machine with some newer kernel running at 
the moment; that's why I actually couldn't test
if the above solution really works...

I read about process namespaces @ http://lwn.net/Articles/259217/
and I'm not quite sure, what one should do (even in general) with these. 
Being exact, a call like "pid()" or "sid()"
is not "valid" anymore, since you need to specify the pid namespace. The 
easiest thing to do is to always pull out the
virtual pid implicitly. But but then, the user should at least know that 
systemtap chose the virtual one.

What do you think about that?

Malte

  reply	other threads:[~2009-05-11 12:21 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-05-08 15:04 Malte Nuhn
2009-05-08 20:06 ` Josh Stone
2009-05-11 12:21   ` Malte Nuhn [this message]
2009-05-11 18:22     ` Josh Stone

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4A081834.8080004@physik.rwth-aachen.de \
    --to=nuhn@physik.rwth-aachen.de \
    --cc=jistone@redhat.com \
    --cc=systemtap@sources.redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).