From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <systemtap-return-12294-listarch-systemtap=sources.redhat.com@sourceware.org>
Received: (qmail 19457 invoked by alias); 11 May 2009 13:47:06 -0000
Received: (qmail 19449 invoked by uid 22791); 11 May 2009 13:47:05 -0000
X-SWARE-Spam-Status: No, hits=-2.0 required=5.0 	tests=AWL,BAYES_00,SPF_HELO_PASS,SPF_PASS
X-Spam-Check-By: sourceware.org
Received: from mx1.redhat.com (HELO mx1.redhat.com) (66.187.233.31)     by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Mon, 11 May 2009 13:46:59 +0000
Received: from int-mx1.corp.redhat.com (int-mx1.corp.redhat.com [172.16.52.254]) 	by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id n4BDkvBc006163 	for <systemtap@sources.redhat.com>; Mon, 11 May 2009 09:46:57 -0400
Received: from ns3.rdu.redhat.com (ns3.rdu.redhat.com [10.11.255.199]) 	by int-mx1.corp.redhat.com (8.13.1/8.13.1) with ESMTP id n4BDktGh023945 	for <systemtap@sources.redhat.com>; Mon, 11 May 2009 09:46:56 -0400
Received: from [10.16.10.94] (vpn-10-94.bos.redhat.com [10.16.10.94]) 	by ns3.rdu.redhat.com (8.13.8/8.13.8) with ESMTP id n4BDkqit004003; 	Mon, 11 May 2009 09:46:53 -0400
Message-ID: <4A082CC4.5000601@redhat.com>
Date: Mon, 11 May 2009 13:47:00 -0000
From: Masami Hiramatsu <mhiramat@redhat.com>
User-Agent: Thunderbird 2.0.0.21 (X11/20090320)
MIME-Version: 1.0
To: Christoph Hellwig <hch@infradead.org>
CC: Ingo Molnar <mingo@elte.hu>, Steven Rostedt <rostedt@goodmis.org>,         lkml <linux-kernel@vger.kernel.org>,         systemtap <systemtap@sources.redhat.com>, kvm <kvm@vger.kernel.org>,         Harvey Harrison <harvey.harrison@gmail.com>,         Thomas Gleixner <tglx@linutronix.de>, Jan Blunck <jblunck@suse.de>
Subject: Re: [PATCH -tip v5 5/7] x86: fix kernel_trap_sp()
References: <20090509004829.5505.38720.stgit@localhost.localdomain> <20090509004904.5505.59034.stgit@localhost.localdomain> <20090511092841.GB23875@infradead.org>
In-Reply-To: <20090511092841.GB23875@infradead.org>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
X-IsSubscribed: yes
Mailing-List: contact systemtap-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <systemtap.sourceware.org>
List-Subscribe: <mailto:systemtap-subscribe@sourceware.org>
List-Post: <mailto:systemtap@sourceware.org>
List-Help: <mailto:systemtap-help@sourceware.org>, <http://sourceware.org/lists.html#faqs>
Sender: systemtap-owner@sourceware.org
X-SW-Source: 2009-q2/txt/msg00538.txt.bz2

Christoph Hellwig wrote:
> On Fri, May 08, 2009 at 08:49:04PM -0400, Masami Hiramatsu wrote:
>> Use &regs->sp instead of regs for getting the top of stack in kernel mode.
>> (on x86-64, regs->sp always points the top of stack)
> 
> Shouldn't this patch be sent for inclusion ASAP instead of sitting in
> this series?

Yes, and it's just for asking a comment from oprofile developers,
because this change will change its behavior a bit.

Anyway, I'll post it separately against upstream.

Thank you,

-- 
Masami Hiramatsu

Software Engineer
Hitachi Computer Products (America) Inc.
Software Solutions Division

e-mail: mhiramat@redhat.com