From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 28780 invoked by alias); 11 May 2009 20:04:20 -0000 Received: (qmail 28765 invoked by uid 22791); 11 May 2009 20:04:18 -0000 X-SWARE-Spam-Status: No, hits=-2.0 required=5.0 tests=AWL,BAYES_00,SPF_HELO_PASS,SPF_PASS X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (66.187.233.31) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Mon, 11 May 2009 20:04:10 +0000 Received: from int-mx1.corp.redhat.com (int-mx1.corp.redhat.com [172.16.52.254]) by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id n4BK43Mu028577 for ; Mon, 11 May 2009 16:04:03 -0400 Received: from ns3.rdu.redhat.com (ns3.rdu.redhat.com [10.11.255.199]) by int-mx1.corp.redhat.com (8.13.1/8.13.1) with ESMTP id n4BK42TN002058 for ; Mon, 11 May 2009 16:04:02 -0400 Received: from [10.16.10.94] (vpn-10-94.bos.redhat.com [10.16.10.94]) by ns3.rdu.redhat.com (8.13.8/8.13.8) with ESMTP id n4BK3uel014792; Mon, 11 May 2009 16:03:57 -0400 Message-ID: <4A088523.6080003@redhat.com> Date: Mon, 11 May 2009 20:04:00 -0000 From: Masami Hiramatsu User-Agent: Thunderbird 2.0.0.21 (X11/20090320) MIME-Version: 1.0 To: Steven Rostedt CC: Ingo Molnar , lkml , Avi Kivity , "H. Peter Anvin" , Frederic Weisbecker , Ananth N Mavinakayanahalli , Andrew Morton , Andi Kleen , Jim Keniston , "K.Prasad" , KOSAKI Motohiro , systemtap , kvm , Tom Zanussi Subject: Re: [PATCH -tip v5 0/7] tracing: kprobe-based event tracer and x86 instruction decoder References: <20090509004829.5505.38720.stgit@localhost.localdomain> <20090509044302.GH8007@elte.hu> <4A0838E6.2000309@redhat.com> In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit X-IsSubscribed: yes Mailing-List: contact systemtap-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Post: List-Help: , Sender: systemtap-owner@sourceware.org X-SW-Source: 2009-q2/txt/msg00552.txt.bz2 Steven Rostedt wrote: > On Mon, 11 May 2009, Masami Hiramatsu wrote: >>> Two high-level comments: >>> >>> - There's no self-test - would it be possible to add one? See >>> trace_selftest* in kernel/trace/ >> I'm not so sure. Currently, it seems that those self-tests are >> only for tracers which define new event-entry on ring-buffer. >> Since this tracer just use ftrace_bprintk, it might need >> another kind of selftest. e.g. comparing outputs with >> expected patterns. >> In that case, would it be better to make a user-space self test >> including filters and tracepoints? > > Or have the workings in the selftest in kernel. As if a user started it. > It does not need to write to the ring buffer, that is just what I did. The > event selftests don't check if anything was written to the ring buffer, > they just make sure that the tests don't crash the system. Would you mean that it is enough to enable some probes and just see what happened at boot time? That's so easy to add. Thank you :-), -- Masami Hiramatsu Software Engineer Hitachi Computer Products (America) Inc. Software Solutions Division e-mail: mhiramat@redhat.com