public inbox for systemtap@sourceware.org
 help / color / mirror / Atom feed
From: Josh Stone <jistone@redhat.com>
To: paulmck@linux.vnet.ibm.com
Cc: Darren Hart <dvhltc@us.ibm.com>, Kiran <kiran@linux.vnet.ibm.com>,
	        systemtap@sources.redhat.com, sripathi@in.ibm.com,
	jkenisto@us.ibm.com
Subject: Re: BUG: [preempt-rt] scheduling while atomic: stapio
Date: Wed, 27 May 2009 22:03:00 -0000	[thread overview]
Message-ID: <4A1DB8A0.3050909@redhat.com> (raw)
In-Reply-To: <20090527210159.GF6729@linux.vnet.ibm.com>

On 05/27/2009 02:01 PM, Paul E. McKenney wrote:
> On Wed, May 27, 2009 at 09:43:22AM -0700, Darren Hart wrote:
>> Josh Stone wrote:
>>> On 05/20/2009 02:44 AM, Kiran wrote:
>>>> BUG: scheduling while atomic: stapio/0x00000001/26142, CPU#3
>>>> [...]
>>>>  [<ffffffff812a2dea>] cpufreq_unregister_notifier+0x35/0x5c
>>>>  [<ffffffffa02e0a1f>] _stp_kill_time+0xb6/0xbd 
>>>> [stap_246f93f30a500769142af9987624737a_5072]
>>>>  [<ffffffffa02e1749>] probe_1391+0x3c/0xa8 
>>>> [stap_246f93f30a500769142af9987624737a_5072]
>>>>  [<ffffffffa02e2621>] enter_end_probe+0x14a/0x1e3 
>>>> [stap_246f93f30a500769142af9987624737a_5072]
>>> enter_end_probe will call preempt_disable, and apparently the call path
>>> from cpufreq_unregister_notifier can sleep.  Is this true only of the RT
>>> kernel?
>>
>> The call into the __synchronize_sched() from synchronize_rcu() appears to 
>> be able to sleep regardless of -rt.  It's possible -rt is more likely to 
>> make them sleep.
> 
> One would expect __synchronize_sched() to sleep, except on non-rt
> uniprocessor systems.  So a uniprocessor system might well see this
> only when running -rt.

Thanks for the confirmation guys.  I went ahead and rearranged our code
that calls cpufreq_unregister_notifier to run in a context that is
permitted to sleep, so it shouldn't be a problem anymore.

Josh

      reply	other threads:[~2009-05-27 22:03 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-05-20  9:44 Kiran
2009-05-20 16:17 ` Jim Keniston
2009-05-27 17:45   ` Darren Hart
2009-05-20 19:22 ` Josh Stone
2009-05-27 17:45   ` Darren Hart
2009-05-27 21:02     ` Paul E. McKenney
2009-05-27 22:03       ` Josh Stone [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4A1DB8A0.3050909@redhat.com \
    --to=jistone@redhat.com \
    --cc=dvhltc@us.ibm.com \
    --cc=jkenisto@us.ibm.com \
    --cc=kiran@linux.vnet.ibm.com \
    --cc=paulmck@linux.vnet.ibm.com \
    --cc=sripathi@in.ibm.com \
    --cc=systemtap@sources.redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).