From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 11762 invoked by alias); 16 Jul 2009 20:47:21 -0000 Received: (qmail 11752 invoked by uid 22791); 16 Jul 2009 20:47:20 -0000 X-SWARE-Spam-Status: No, hits=-1.8 required=5.0 tests=AWL,BAYES_00,SPF_HELO_PASS,SPF_PASS X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (66.187.233.31) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Thu, 16 Jul 2009 20:47:12 +0000 Received: from int-mx1.corp.redhat.com (int-mx1.corp.redhat.com [172.16.52.254]) by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id n6GKlAjK010285 for ; Thu, 16 Jul 2009 16:47:10 -0400 Received: from ns3.rdu.redhat.com (ns3.rdu.redhat.com [10.11.255.199]) by int-mx1.corp.redhat.com (8.13.1/8.13.1) with ESMTP id n6GKlAP1028985 for ; Thu, 16 Jul 2009 16:47:10 -0400 Received: from [10.11.10.37] (vpn-10-37.rdu.redhat.com [10.11.10.37]) by ns3.rdu.redhat.com (8.13.8/8.13.8) with ESMTP id n6GKl7JP018052; Thu, 16 Jul 2009 16:47:07 -0400 Message-ID: <4A5F9228.7060904@redhat.com> Date: Thu, 16 Jul 2009 20:47:00 -0000 From: Masami Hiramatsu User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9.1b3pre) Gecko/20090513 Fedora/3.0-2.3.beta2.fc11 Thunderbird/3.0b2 MIME-Version: 1.0 To: Ingo Molnar , Steven Rostedt , lkml , systemtap , kvm , Jim Keniston , "H. Peter Anvin" , Ananth N Mavinakayanahalli , Srikar Dronamraju , Frederic Weisbecker , Andi Kleen , Vegard Nossum , Avi Kivity , Przemys??awPawe??czyk Subject: Re: [PATCH -tip -v12 01/11] x86: instruction decoder API References: <20090716155652.6266.39970.stgit@localhost.localdomain> <20090716155700.6266.71011.stgit@localhost.localdomain> <20090716163708.GB5804@merkur.ravnborg.org> <4A5F6356.9080505@redhat.com> <20090716200012.GB5994@merkur.ravnborg.org> In-Reply-To: <20090716200012.GB5994@merkur.ravnborg.org> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit X-IsSubscribed: yes Mailing-List: contact systemtap-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Post: List-Help: , Sender: systemtap-owner@sourceware.org X-SW-Source: 2009-q3/txt/msg00148.txt.bz2 Sam Ravnborg wrote: > On Thu, Jul 16, 2009 at 01:28:54PM -0400, Masami Hiramatsu wrote: >> Sam Ravnborg wrote: >>>> diff --git a/arch/x86/include/asm/inat.h b/arch/x86/include/asm/inat.h >>>> new file mode 100644 >>>> index 0000000..01e079a >>>> --- /dev/null >>>> +++ b/arch/x86/include/asm/inat.h >>>> @@ -0,0 +1,125 @@ >>>> +#ifndef _ASM_INAT_INAT_H >>>> +#define _ASM_INAT_INAT_H >>> [With reference to comment on patch 2/12...] >>> You create inat.h here. >>> Could you investigave what is needed to factor out the stuff >>> needed from userspace so we can avoid the ugly havk where >>> you redefine types.h? >> Sorry, I'm a bit confusing. >> Would you mean that I should break down user_include.h and >> add those redefined types in inat.h? > No - try to factor out what is needed for your program > so you can avoid user_include.h entirely. >>> Maybe create a inat_types.h + inat.h as we do in other cases? >> And inat_types.h has two parts, one for kernel, and one for >> userspace(which is moved from user_include.h), is that right? > More like inat_types.h include pure definitions and inat.h > define all the macros (that would be much nicer if expressed > as static inlines). OK, some macros still need to be macros, because it will be used for defining static tables. > The real thing to consider is what is needed from your userspace > program and is also required by the kernel. > I did not event remotely try to find out - as I guess you know it. > So try to isolate these bits somehow and you have then nicely dropped > a lot of dependencies on the remainign headers and can thus > hopefully get rid of the ugly usser_include.h hack. OK, I'll try to remove user_include.h hack. Thank you so much! -- Masami Hiramatsu Software Engineer Hitachi Computer Products (America), Inc. Software Solutions Division e-mail: mhiramat@redhat.com