public inbox for systemtap@sourceware.org
 help / color / mirror / Atom feed
From: David Smith <dsmith@redhat.com>
To: "Frank Ch. Eigler" <fche@redhat.com>
Cc: systemtap@sources.redhat.com
Subject: Re: PR4186: cross-compilation, $ARCH
Date: Tue, 25 Aug 2009 15:13:00 -0000	[thread overview]
Message-ID: <4A93FF8B.8030000@redhat.com> (raw)
In-Reply-To: <20090825145012.GB28204@redhat.com>

On 08/25/2009 09:50 AM, Frank Ch. Eigler wrote:
> Hi -
> 
>> [...]
>> - Are we planning on extending '%arch' (or perhaps adding '%user_arch')
>> to tell the difference between 32-bit and 64-bit user exes?
> 
> This would makes sense only as a per-probe-point construct, since the
> same stap script on a 64-bit host can instrument 32- and 64-bit
> userspace programs just fine.
> 
> 
>> - I'd probably go with solution #2 [switching to kernel "arch"], but
>> also provide "aliases" for the old names (assuming that's possible).
> 
> I don't know.  We'd have to handle things like
>   %( arch == "i686" %? /*A*/ %: /*B*/ %) 
> and also
>   %( arch == "i686" %? /*A*/ %: %( arch == "i386" %? /*B*/ %: /*C*/ %) %)
> 
> - FChE

I'm not sure I explained myself well about the aliases (or I didn't read
your response correctly).  What I'm suggesting is that the following
*both* match:

%(arch == "i686" %? /*A*/ %)

%(arch == "i386" %? /*A*/ %)

i.e., in the translator, let arch matching be done with a wildcard.  In
the case of x86, it would be like checking the user's string against the
regular expression 'i[3-6]86'.

I just poked through the tapsets, and it seems that when i386/i686 are
looked at, both cases appear to be handled the same anyway, so it
wouldn't really matter if both matched.

-- 
David Smith
dsmith@redhat.com
Red Hat
http://www.redhat.com
256.217.0141 (direct)
256.837.0057 (fax)

  reply	other threads:[~2009-08-25 15:13 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-08-25 13:54 Frank Ch. Eigler
2009-08-25 14:42 ` David Smith
2009-08-25 14:50   ` Frank Ch. Eigler
2009-08-25 15:13     ` David Smith [this message]
2009-08-25 15:15       ` Frank Ch. Eigler
2009-08-27 20:28     ` Mark Wielaard

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4A93FF8B.8030000@redhat.com \
    --to=dsmith@redhat.com \
    --cc=fche@redhat.com \
    --cc=systemtap@sources.redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).