* [PATCH 1/2] tracing: Fix minor bugs for __unregister_ftrace_function_probe
@ 2009-09-15 10:09 Atsushi Tsuji
2009-09-16 13:06 ` Steven Rostedt
0 siblings, 1 reply; 2+ messages in thread
From: Atsushi Tsuji @ 2009-09-15 10:09 UTC (permalink / raw)
To: linux-kernel, rostedt, Ingo Molnar, fweisbec, Frank Ch. Eigler
Cc: Peter Zijlstra, paulus, systemtap
Fix the condition of strcmp for "*".
Also fix NULL pointer dereference when glob is NULL.
Signed-off-by: Atsushi Tsuji <a-tsuji@bk.jp.nec.com>
---
kernel/trace/ftrace.c | 4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/kernel/trace/ftrace.c b/kernel/trace/ftrace.c
index 8c804e2..5ef8f59 100644
--- a/kernel/trace/ftrace.c
+++ b/kernel/trace/ftrace.c
@@ -2059,9 +2059,9 @@ __unregister_ftrace_function_probe(char *glob, struct ftrace_probe_ops *ops,
int i, len = 0;
char *search;
- if (glob && (strcmp(glob, "*") || !strlen(glob)))
+ if (glob && (strcmp(glob, "*") == 0 || !strlen(glob)))
glob = NULL;
- else {
+ else if (glob) {
int not;
type = ftrace_setup_glob(glob, strlen(glob), &search, ¬);
--
1.5.5.1
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH 1/2] tracing: Fix minor bugs for __unregister_ftrace_function_probe
2009-09-15 10:09 [PATCH 1/2] tracing: Fix minor bugs for __unregister_ftrace_function_probe Atsushi Tsuji
@ 2009-09-16 13:06 ` Steven Rostedt
0 siblings, 0 replies; 2+ messages in thread
From: Steven Rostedt @ 2009-09-16 13:06 UTC (permalink / raw)
To: Atsushi Tsuji
Cc: linux-kernel, Ingo Molnar, fweisbec, Frank Ch. Eigler,
Peter Zijlstra, paulus, systemtap
On Tue, 2009-09-15 at 19:06 +0900, Atsushi Tsuji wrote:
> Fix the condition of strcmp for "*".
> Also fix NULL pointer dereference when glob is NULL.
>
> Signed-off-by: Atsushi Tsuji <a-tsuji@bk.jp.nec.com>
This is a real fix, I'll pull it in separately.
Thanks!
-- Steve
> ---
> kernel/trace/ftrace.c | 4 ++--
> 1 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/kernel/trace/ftrace.c b/kernel/trace/ftrace.c
> index 8c804e2..5ef8f59 100644
> --- a/kernel/trace/ftrace.c
> +++ b/kernel/trace/ftrace.c
> @@ -2059,9 +2059,9 @@ __unregister_ftrace_function_probe(char *glob, struct ftrace_probe_ops *ops,
> int i, len = 0;
> char *search;
>
> - if (glob && (strcmp(glob, "*") || !strlen(glob)))
> + if (glob && (strcmp(glob, "*") == 0 || !strlen(glob)))
> glob = NULL;
> - else {
> + else if (glob) {
> int not;
>
> type = ftrace_setup_glob(glob, strlen(glob), &search, ¬);
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2009-09-16 13:06 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2009-09-15 10:09 [PATCH 1/2] tracing: Fix minor bugs for __unregister_ftrace_function_probe Atsushi Tsuji
2009-09-16 13:06 ` Steven Rostedt
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).