From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 30358 invoked by alias); 30 Sep 2009 20:55:59 -0000 Received: (qmail 30344 invoked by uid 22791); 30 Sep 2009 20:55:58 -0000 X-SWARE-Spam-Status: No, hits=-2.6 required=5.0 tests=AWL,BAYES_00 X-Spam-Check-By: sourceware.org Received: from e24smtp01.br.ibm.com (HELO e24smtp01.br.ibm.com) (32.104.18.85) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Wed, 30 Sep 2009 20:55:54 +0000 Received: from d24relay01.br.ibm.com (d24relay01.br.ibm.com [9.8.31.16]) by e24smtp01.br.ibm.com (8.14.3/8.13.1) with ESMTP id n8UL0fk7017369 for ; Wed, 30 Sep 2009 18:00:41 -0300 Received: from d24av01.br.ibm.com (d24av01.br.ibm.com [9.18.232.46]) by d24relay01.br.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id n8UKtpJ03637402 for ; Wed, 30 Sep 2009 17:55:51 -0300 Received: from d24av01.br.ibm.com (loopback [127.0.0.1]) by d24av01.br.ibm.com (8.12.11.20060308/8.13.3) with ESMTP id n8UKtonp011764 for ; Wed, 30 Sep 2009 17:55:51 -0300 Received: from [9.8.0.246] ([9.8.0.246]) by d24av01.br.ibm.com (8.12.11.20060308/8.12.11) with ESMTP id n8UKtoBj010498; Wed, 30 Sep 2009 17:55:50 -0300 Message-ID: <4AC3C5A5.8070403@linux.vnet.ibm.com> Date: Wed, 30 Sep 2009 20:55:00 -0000 From: Breno Leitao User-Agent: Thunderbird 2.0.0.23 (X11/20090817) MIME-Version: 1.0 To: "Frank Ch. Eigler" CC: systemtap@sources.redhat.com Subject: Re: [PATCH] Create a function that indents without the tid() References: <4AC39EFA.50407@linux.vnet.ibm.com> <4AC3B809.9040503@linux.vnet.ibm.com> In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-IsSubscribed: yes Mailing-List: contact systemtap-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Post: List-Help: , Sender: systemtap-owner@sourceware.org X-SW-Source: 2009-q3/txt/msg00907.txt.bz2 Frank Ch. Eigler wrote: > Breno Leitao writes: > >> [...] >>> function indent(delta) { return _generic_indent(0, delta) } > >> Well, it makes sense, and it was my first implementation, but later I found that >> tid() can be 0, and then the space counter (_indent_counters[idx]) will be >> corrupted when running indent() and thread_indent() together. [...] > > Well, ok, how about { return _generic_indent(-1, delta) } ? Nice. It works. Silly me, I didn't think about negative indexes. The only problem I see now, is that it will display the scheduled process, and since the process names have different lengths, the alignment will be lost and sometimes it's difficult to follow/read, as an example I just got. 534776 a.out(6928): -> neo_set_no_input_flow_control 535094 swapper(0): <- neo_parse_modem 535357 a.out(6928): <- neo_set_no_input_flow_control So, if this is not important, I can submit a new patch with the implementation as you just described. Thanks