From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 10099 invoked by alias); 7 Oct 2009 03:20:25 -0000 Received: (qmail 10091 invoked by uid 22791); 7 Oct 2009 03:20:24 -0000 X-SWARE-Spam-Status: No, hits=-2.4 required=5.0 tests=AWL,BAYES_00,SPF_HELO_PASS,SPF_PASS X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Wed, 07 Oct 2009 03:20:17 +0000 Received: from int-mx02.intmail.prod.int.phx2.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id n973KFTm028779 for ; Tue, 6 Oct 2009 23:20:16 -0400 Received: from [10.11.11.207] (vpn-11-207.rdu.redhat.com [10.11.11.207]) by int-mx02.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id n973KBdN022324; Tue, 6 Oct 2009 23:20:12 -0400 Message-ID: <4ACC0963.5080403@redhat.com> Date: Wed, 07 Oct 2009 03:20:00 -0000 From: Masami Hiramatsu User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9.1.1) Gecko/20090814 Fedora/3.0-2.6.b3.fc11 Thunderbird/3.0b3 MIME-Version: 1.0 To: Peter Zijlstra CC: rostedt@goodmis.org, Frederic Weisbecker , Ingo Molnar , lkml , systemtap , DLE , Thomas Gleixner , Arnaldo Carvalho de Melo , Mike Galbraith , Paul Mackerras , Christoph Hellwig , Ananth N Mavinakayanahalli , Jim Keniston , "Frank Ch. Eigler" Subject: Re: [PATCH tracing/kprobes v2 4/5] perf: Add perf probe subcommand for kprobe-event setup helper References: <20091002214834.30906.86502.stgit@dhcp-100-2-132.bos.redhat.com> <20091002214904.30906.11622.stgit@dhcp-100-2-132.bos.redhat.com> <1254788953.13160.209.camel@gandalf.stny.rr.com> <4ACA95F8.7020407@redhat.com> <1254819822.21044.125.camel@laptop> In-Reply-To: <1254819822.21044.125.camel@laptop> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit X-IsSubscribed: yes Mailing-List: contact systemtap-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Post: List-Help: , Sender: systemtap-owner@sourceware.org X-SW-Source: 2009-q4/txt/msg00076.txt.bz2 Peter Zijlstra wrote: > On Mon, 2009-10-05 at 20:57 -0400, Masami Hiramatsu wrote: >>>> +ifneq ($(shell sh -c "(echo '\#include '; echo '\#include '; echo 'int main(void) { Dwarf_Debug dbg; Dwarf_Error err; dwarf_init(0, DW_DLC_READ, 0, 0, &dbg, &err); return (long)dbg; }') | $(CC) -x c - $(ALL_CFLAGS) -D_LARGEFILE64_SOURCE -D_FILE_OFFSET_BITS=64 -ldwarf -lelf -o /dev/null $(ALL_LDFLAGS) > /dev/null 2>&1 && echo y"), y) >>>> + msg := $(warning No libdwarf.h found, disables probe subcommand. Please install libdwarf-dev/libdwarf-devel); >>> >>> Wow! And I thought my macros were ugly ;-) >> >> :-) >> Maybe, would I better make a separate c file to check this? >> Like "autoconf-checkdwarf.c". > > I'm the one who started this trend.. Maybe putting all those tests in a > static .c file makes sense now, put them in a tests/ or checks/ > directory though, so it doesn't litter the regular files. > > Then again,.. the actual .c file is only half that line, so it doesn't > really clean up that much. Yeah, ok, then I'll leave this part in this series. It's better to be done in another series. Thank you, -- Masami Hiramatsu Software Engineer Hitachi Computer Products (America), Inc. Software Solutions Division e-mail: mhiramat@redhat.com