From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 29498 invoked by alias); 13 Oct 2009 01:02:57 -0000 Received: (qmail 29371 invoked by uid 22791); 13 Oct 2009 01:02:56 -0000 X-SWARE-Spam-Status: No, hits=-2.0 required=5.0 tests=AWL,BAYES_00,SPF_HELO_PASS,SPF_PASS X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 13 Oct 2009 01:02:51 +0000 Received: from int-mx01.intmail.prod.int.phx2.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id n9D12mBL006401; Mon, 12 Oct 2009 21:02:48 -0400 Received: from [10.3.226.31] (vpn-226-31.phx2.redhat.com [10.3.226.31]) by int-mx01.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id n9D12l6o024478; Mon, 12 Oct 2009 21:02:48 -0400 Message-ID: <4AD3D1B7.9060306@redhat.com> Date: Tue, 13 Oct 2009 01:02:00 -0000 From: Josh Stone User-Agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.1.4pre) Gecko/20090922 Fedora/3.0-2.7.b4.fc11 Lightning/1.0pre Thunderbird/3.0b4 MIME-Version: 1.0 To: Przemyslaw Pawelczyk CC: systemtap@sourceware.org Subject: Re: [PATCH 1/2] Add the .call modifier to syscall entry probes. References: <1255172131.839802.8753@debian> In-Reply-To: <1255172131.839802.8753@debian> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-IsSubscribed: yes Mailing-List: contact systemtap-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Post: List-Help: , Sender: systemtap-owner@sourceware.org X-SW-Source: 2009-q4/txt/msg00147.txt.bz2 On 10/10/2009 03:14 AM, Przemyslaw Pawelczyk wrote: > Inline functions do not have an indentifiable return point and require > kernel built using VTA-enabled gcc to get tracking of variables. OTOH > syscall functions are very rarely inlined (depending on the compiler > mood), therefore filtering probes to include only non-inlined functions > ensures consistent behavior between different kernels. > > This removes the problem of inaccessible variables in inlined syscalls > that is described in comments #6-9 to PR5890 and gives us the status quo > w.r.t. syscall probing, because before the commit solving PR10572 > (b7478964) inline instances were masked anyway by non-inline ones. This is now committed - thanks! Josh