From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 8829 invoked by alias); 29 Oct 2009 14:19:01 -0000 Received: (qmail 8615 invoked by uid 22791); 29 Oct 2009 14:19:00 -0000 X-SWARE-Spam-Status: No, hits=-2.5 required=5.0 tests=AWL,BAYES_00,SPF_HELO_PASS,SPF_PASS X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Thu, 29 Oct 2009 14:18:54 +0000 Received: from int-mx08.intmail.prod.int.phx2.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.21]) by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id n9TEIr9B018771 for ; Thu, 29 Oct 2009 10:18:53 -0400 Received: from [10.16.2.46] (dhcp-100-2-46.bos.redhat.com [10.16.2.46]) by int-mx08.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id n9TEIqhu004392; Thu, 29 Oct 2009 10:18:53 -0400 Message-ID: <4AE9A44C.4040204@redhat.com> Date: Thu, 29 Oct 2009 14:19:00 -0000 From: Masami Hiramatsu User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9.1.4pre) Gecko/20091014 Fedora/3.0-2.8.b4.fc11 Thunderbird/3.0b4 MIME-Version: 1.0 To: mahesh@linux.vnet.ibm.com CC: Wenji Huang , systemtap@sources.redhat.com Subject: Re: [PATCH -tip tracing/kprobes] Powerpc port of the kprobe-based event tracer. References: <20091020121505.724222003@mars.in.ibm.com> <4AE65F54.70800@oracle.com> <20091029051053.GA17527@in.ibm.com> In-Reply-To: <20091029051053.GA17527@in.ibm.com> Content-Type: text/plain; charset=ISO-2022-JP Content-Transfer-Encoding: 7bit X-IsSubscribed: yes Mailing-List: contact systemtap-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Post: List-Help: , Sender: systemtap-owner@sourceware.org X-SW-Source: 2009-q4/txt/msg00350.txt.bz2 Mahesh J Salgaonkar wrote: > On Tue, Oct 27, 2009 at 10:47:48AM +0800, Wenji Huang wrote: >> Hi, >> > > Thanks for reviewing changes. I have addressed all your suggestions. > >> [...] >>> + * regs_within_kernel_stack() - check the address in the stack >>> + * @regs: pt_regs which contains kernel stack pointer. >>> + * @addr: address which is checked. >>> + * >>> + * regs_within_kenel_stack() checks @addr is within the kernel stack page(s). >>> + * If @addr is within the kernel stack, it returns true. If not, returns false. >> >> s/regs_within_kenel_stack/regs_within_kernel_stack/ >> The return type function is declared as int. > > Changed it to bool. This code has been taken from x86 port. We may have > to fix this there too. Thanks Mahesh and Wenji! Please feel free to post the x86 fix patch too :-) > >>> + */ >>> + >>> +static inline int regs_within_kernel_stack(struct pt_regs *regs, >>> + unsigned long addr) >>> +{ >>> + return ((addr& ~(THREAD_SIZE - 1)) == >>> + (kernel_stack_pointer(regs)& ~(THREAD_SIZE - 1))); >>> +} >>> + >> >> Regards, >> Wenji > > Please find the modified patch atached. Acked-by: Masami Hiramatsu Thanks! -- Masami Hiramatsu Software Engineer Hitachi Computer Products (America), Inc. Software Solutions Division e-mail: mhiramat@redhat.com