From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 18695 invoked by alias); 2 Nov 2009 21:16:35 -0000 Received: (qmail 18687 invoked by uid 22791); 2 Nov 2009 21:16:35 -0000 X-SWARE-Spam-Status: No, hits=-2.5 required=5.0 tests=AWL,BAYES_00,SPF_HELO_PASS,SPF_PASS X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Mon, 02 Nov 2009 21:16:30 +0000 Received: from int-mx08.intmail.prod.int.phx2.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.21]) by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id nA2LGTjN022132 for ; Mon, 2 Nov 2009 16:16:29 -0500 Received: from [10.16.2.46] (dhcp-100-2-46.bos.redhat.com [10.16.2.46]) by int-mx08.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id nA2LGPg4017490; Mon, 2 Nov 2009 16:16:25 -0500 Message-ID: <4AEF4C29.2060501@redhat.com> Date: Mon, 02 Nov 2009 21:16:00 -0000 From: Masami Hiramatsu User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9.1.4pre) Gecko/20091014 Fedora/3.0-2.8.b4.fc11 Thunderbird/3.0b4 MIME-Version: 1.0 To: Ingo Molnar CC: Arnaldo Carvalho de Melo , =?ISO-8859-1?Q?Fr=E9d=E9r?= =?ISO-8859-1?Q?ic_Weisbecker?= , lkml , Steven Rostedt , Jim Keniston , Ananth N Mavinakayanahalli , Christoph Hellwig , "Frank Ch. Eigler" , "H. Peter Anvin" , Jason Baron , "K.Prasad" , Peter Zijlstra , Srikar Dronamraju , systemtap , DLE Subject: Re: [PATCH -tip perf/probes 00/10] x86 insn decoder bugfixes and perf-probe syntax changes References: <20091027204156.30545.96425.stgit@harusame> <20091029085348.GD26970@elte.hu> <4AE9C919.4070003@redhat.com> In-Reply-To: <4AE9C919.4070003@redhat.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-IsSubscribed: yes Mailing-List: contact systemtap-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Post: List-Help: , Sender: systemtap-owner@sourceware.org X-SW-Source: 2009-q4/txt/msg00388.txt.bz2 Masami Hiramatsu wrote: > Ingo Molnar wrote: >> What we want here is two fold: >> >> - enable kprobes event support when perf events is enabled and kprobes >> is enabled. We dont want another config option for it. > > Sure, at least that combination should enable kprobe-tracer forcibly. Hmm, someone may not want to enables kprobe-tracer. Perhaps, "default y if (EVENT_PROFILE)" is enough, isn't it? >> A few further (and very small) UI tweaks i'd suggest: >> >> Firstly, could we please make the first probe inserted named plain after >> the symbol it specifies, with no _0 postfix? I.e. instead of: >> >> 7358 perfprobe:__switch_to_0 # 0.000 M/sec >> >> we'd get: >> >> 7358 perfprobe:__switch_to # 0.000 M/sec >> >> Subsequent probes for the same symbol can be named _1, _2 - but the >> first symbol should not have this needless post-fix. > > Ah, this prefix means the offset from the symbol. Of course we can > remove it if the offset == 0. Or, would you think make the postfix > sequence number of probes on the same symbol? If so, we'd better have --list option before that and check the postfix is already used, since we may not want to overwrite existing probes, right? Thank you, -- Masami Hiramatsu Software Engineer Hitachi Computer Products (America), Inc. Software Solutions Division e-mail: mhiramat@redhat.com