From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 11276 invoked by alias); 2 Nov 2009 21:57:08 -0000 Received: (qmail 11269 invoked by uid 22791); 2 Nov 2009 21:57:07 -0000 X-SWARE-Spam-Status: No, hits=-2.5 required=5.0 tests=AWL,BAYES_00,SPF_HELO_PASS,SPF_PASS X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Mon, 02 Nov 2009 21:57:04 +0000 Received: from int-mx03.intmail.prod.int.phx2.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.16]) by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id nA2Lv2qK027531 for ; Mon, 2 Nov 2009 16:57:02 -0500 Received: from [10.16.2.46] (dhcp-100-2-46.bos.redhat.com [10.16.2.46]) by int-mx03.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id nA2LuxAr029385; Mon, 2 Nov 2009 16:57:00 -0500 Message-ID: <4AEF55AB.50701@redhat.com> Date: Mon, 02 Nov 2009 21:57:00 -0000 From: Masami Hiramatsu User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9.1.4pre) Gecko/20091014 Fedora/3.0-2.8.b4.fc11 Thunderbird/3.0b4 MIME-Version: 1.0 To: Frederic Weisbecker CC: Ingo Molnar , Arnaldo Carvalho de Melo , lkml , Steven Rostedt , Jim Keniston , Ananth N Mavinakayanahalli , Christoph Hellwig , "Frank Ch. Eigler" , "H. Peter Anvin" , Jason Baron , "K.Prasad" , Peter Zijlstra , Srikar Dronamraju , systemtap , DLE Subject: Re: [PATCH -tip perf/probes 00/10] x86 insn decoder bugfixes and perf-probe syntax changes References: <20091027204156.30545.96425.stgit@harusame> <20091029085348.GD26970@elte.hu> <4AE9C919.4070003@redhat.com> <4AEF4C29.2060501@redhat.com> <20091102212632.GH4880@nowhere> In-Reply-To: <20091102212632.GH4880@nowhere> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-IsSubscribed: yes Mailing-List: contact systemtap-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Post: List-Help: , Sender: systemtap-owner@sourceware.org X-SW-Source: 2009-q4/txt/msg00390.txt.bz2 Frederic Weisbecker wrote: > On Mon, Nov 02, 2009 at 04:16:25PM -0500, Masami Hiramatsu wrote: >> Masami Hiramatsu wrote: >>> Ingo Molnar wrote: >>>> What we want here is two fold: >>>> >>>> - enable kprobes event support when perf events is enabled and kprobes >>>> is enabled. We dont want another config option for it. >>> >>> Sure, at least that combination should enable kprobe-tracer forcibly. >> >> Hmm, someone may not want to enables kprobe-tracer. Perhaps, >> "default y if (EVENT_PROFILE)" is enough, isn't it? >> > > > I guess it should be sufficient yeah. We want to strongly recommend > the kprobe events if we have enabled perf, but we don't want to force > it. > > Also in this case we need a verbose runtime report of the lack of this > tracer in debugfs from perf probe if needed. Sure, error message should be changed as warning user to enable CONFIG_KPROBE_TRACER :-) Thank you, -- Masami Hiramatsu Software Engineer Hitachi Computer Products (America), Inc. Software Solutions Division e-mail: mhiramat@redhat.com