From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 2600 invoked by alias); 16 Nov 2009 21:52:45 -0000 Received: (qmail 2592 invoked by uid 22791); 16 Nov 2009 21:52:44 -0000 X-SWARE-Spam-Status: No, hits=-2.5 required=5.0 tests=AWL,BAYES_00,SPF_HELO_PASS,SPF_PASS X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Mon, 16 Nov 2009 21:51:23 +0000 Received: from int-mx03.intmail.prod.int.phx2.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.16]) by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id nAGLpMsU011030 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Mon, 16 Nov 2009 16:51:22 -0500 Received: from [10.16.2.46] (dhcp-100-2-46.bos.redhat.com [10.16.2.46]) by int-mx03.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id nAGLpK8M015526; Mon, 16 Nov 2009 16:51:21 -0500 Message-ID: <4B01C95B.1070302@redhat.com> Date: Mon, 16 Nov 2009 21:52:00 -0000 From: Masami Hiramatsu User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9.1.4pre) Gecko/20091014 Fedora/3.0-2.8.b4.fc11 Thunderbird/3.0b4 MIME-Version: 1.0 To: Ingo Molnar CC: Roland McGrath , lkml , systemtap , DLE Subject: Re: [PATCH -tip 3/3] Add get_signal tracepoint References: <20091113225226.15079.90813.stgit@harusame> <20091113225240.15079.4863.stgit@harusame> <20091113235333.0E3CC15E8@magilla.sf.frob.com> <20091114001020.GB24738@elte.hu> In-Reply-To: <20091114001020.GB24738@elte.hu> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-IsSubscribed: yes Mailing-List: contact systemtap-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Post: List-Help: , Sender: systemtap-owner@sourceware.org X-SW-Source: 2009-q4/txt/msg00538.txt.bz2 Ingo Molnar wrote: >> Especially if you call this "get" rather than "deliver", there is >> another place that should invoke this tracepoint (or perhaps a third >> one). sys_rt_sigtimedwait "gets" a signal without delivering it. In >> POSIX terminology this is called "accepting" the signal: the three >> things that can happen in the life of a signal are "generate", >> "deliver", and "accept". If you are trying to match up what happened >> to a signal generated by kill() or whatnot, then you want to notice >> both delivery and acceptance as the complementary event. >> >> (And again I have no clue why this signal stuff should be called >> "sched" at all.) > > it shouldnt be called 'sched' - it should go into 'events/signal.h'. > > But we also need fuller coverage than this. Coredumps and signal > delivery events are just a small part of all things signals, we also > want: That's a good idea. I'll put coredump and signal related events into events/signal.h. > > - signal generation events (send_sig*() variants) Those events finally calls __send_signal(), so I think trace_signal_send() can trace those events. > - signal IPI/wakeup events All signals might be used for IPI, isn't it? :-) Or, did you mean SIGSTOP/SIGCONT pare? > - signal loss events (queue overflow) Perhaps, this event is only for rt-signals, since legacy signals just overwritten if it was sent. Thank you, -- Masami Hiramatsu Software Engineer Hitachi Computer Products (America), Inc. Software Solutions Division e-mail: mhiramat@redhat.com