From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 28901 invoked by alias); 17 Nov 2009 06:54:46 -0000 Received: (qmail 28891 invoked by uid 22791); 17 Nov 2009 06:54:44 -0000 X-SWARE-Spam-Status: No, hits=-2.5 required=5.0 tests=AWL,BAYES_00,SPF_HELO_PASS,SPF_PASS X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 17 Nov 2009 06:53:35 +0000 Received: from int-mx08.intmail.prod.int.phx2.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.21]) by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id nAH6rX3g017782 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Tue, 17 Nov 2009 01:53:33 -0500 Received: from [10.11.8.187] (vpn-8-187.rdu.redhat.com [10.11.8.187]) by int-mx08.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id nAH6rV3j016019; Tue, 17 Nov 2009 01:53:32 -0500 Message-ID: <4B0248FA.5040502@redhat.com> Date: Tue, 17 Nov 2009 06:54:00 -0000 From: Masami Hiramatsu User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9.1.4pre) Gecko/20090922 Fedora/3.0-2.7.b4.fc11 Thunderbird/3.0b4 MIME-Version: 1.0 To: Ingo Molnar CC: linux-next@vger.kernel.org, Stephen Rothwell , Randy Dunlap , Jim Keniston , "H. Peter Anvin" , lkml , systemtap , DLE Subject: Re: [PATCH -next 0/3] x86 insn decoder test updates (Re: linux-next: Tree for October 29 (x86 posttest)) References: <20091116230611.5250.86656.stgit@harusame> <20091117061352.GE30852@elte.hu> In-Reply-To: <20091117061352.GE30852@elte.hu> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit X-IsSubscribed: yes Mailing-List: contact systemtap-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Post: List-Help: , Sender: systemtap-owner@sourceware.org X-SW-Source: 2009-q4/txt/msg00551.txt.bz2 Ingo Molnar wrote: > > * Masami Hiramatsu wrote: > >> Here are the patches which update x86 instruction decoder build-time >> test. As Stephen reported on linux-next, sometimes objdump decodes bad >> instructions as normal. This will cause a false positive result on x86 >> insn decoder test. This patches update the test as below; >> >> - Show more information with V=1 >> - Show in which symbol the difference places. >> - Just warning instead of build failure. > > yes, -tip testing was showing such build bugs too: > > Error: ffffffff8104aae3: c5 83 3d 49 80 ee lds 0xffffffffee80493d(%rbx),%eax > Error: objdump says 6 bytes, but insn_get_length() says 3 (attr:0) > > it happens with older tools, such as binutils-2.17. Modern binutils > (2.19) is fine. Thank you for telling me. > We dont want to remove the build error: it helped us fix a number of > real bugs in the decoder - instead please try to create a make based > workaround based on binutils, to not run the test with binutils older > than 2.19 or so. OK, that's fine for me. Thank you, -- Masami Hiramatsu Software Engineer Hitachi Computer Products (America), Inc. Software Solutions Division e-mail: mhiramat@redhat.com