From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 21814 invoked by alias); 18 Nov 2009 16:33:39 -0000 Received: (qmail 21639 invoked by uid 22791); 18 Nov 2009 16:33:37 -0000 X-SWARE-Spam-Status: No, hits=-2.5 required=5.0 tests=AWL,BAYES_00,SPF_HELO_PASS,SPF_PASS X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Wed, 18 Nov 2009 16:32:33 +0000 Received: from int-mx05.intmail.prod.int.phx2.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.18]) by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id nAIGWVmP000932 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Wed, 18 Nov 2009 11:32:32 -0500 Received: from [10.16.2.46] (dhcp-100-2-46.bos.redhat.com [10.16.2.46]) by int-mx05.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id nAIGWUOJ001245; Wed, 18 Nov 2009 11:32:31 -0500 Message-ID: <4B0421A2.1080400@redhat.com> Date: Wed, 18 Nov 2009 16:33:00 -0000 From: Masami Hiramatsu User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9.1.4pre) Gecko/20091014 Fedora/3.0-2.8.b4.fc11 Thunderbird/3.0b4 MIME-Version: 1.0 To: Roland McGrath CC: Ingo Molnar , lkml , Oleg Nesterov , systemtap , DLE Subject: Re: [PATCH -tip 0/3] tracepoint: Add signal events References: <20091117234117.30589.61311.stgit@dhcp-100-2-132.bos.redhat.com> <20091118030706.EB93EA8C@magilla.sf.frob.com> In-Reply-To: <20091118030706.EB93EA8C@magilla.sf.frob.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-IsSubscribed: yes Mailing-List: contact systemtap-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Post: List-Help: , Sender: systemtap-owner@sourceware.org X-SW-Source: 2009-q4/txt/msg00575.txt.bz2 Roland McGrath wrote: > I would add the siginfo_t * argument to each of these tracepoints. I see. Is it OK to record only si_errno and si_code? because si_signo might be as same as sig. > In 2/3 this comment: > > + /* Trace the actual delivered signals including SIG_IGN.*/ > > might be slightly misleading. In most cases SIG_IGN signals won't make it > this far. The same is true of SIG_DFL signals whose default action is to > ignore. So one should be clear that trace_signal_deliver() is by no means > expected to get all SIG_IGN signals that are otherwise eligible for delivery. Ah, thank you for noticing. I'll remove the last words. Thank you, -- Masami Hiramatsu Software Engineer Hitachi Computer Products (America), Inc. Software Solutions Division e-mail: mhiramat@redhat.com