From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 11022 invoked by alias); 24 Nov 2009 21:45:17 -0000 Received: (qmail 11012 invoked by uid 22791); 24 Nov 2009 21:45:16 -0000 X-SWARE-Spam-Status: No, hits=-2.5 required=5.0 tests=AWL,BAYES_00,SPF_HELO_PASS,SPF_PASS X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 24 Nov 2009 21:45:10 +0000 Received: from int-mx03.intmail.prod.int.phx2.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.16]) by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id nAOLj97x011131 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Tue, 24 Nov 2009 16:45:09 -0500 Received: from [10.16.2.46] (dhcp-100-2-46.bos.redhat.com [10.16.2.46]) by int-mx03.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id nAOLj7WJ021160; Tue, 24 Nov 2009 16:45:08 -0500 Message-ID: <4B0C53ED.8060808@redhat.com> Date: Tue, 24 Nov 2009 21:45:00 -0000 From: Masami Hiramatsu User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9.1.4pre) Gecko/20091014 Fedora/3.0-2.8.b4.fc11 Thunderbird/3.0b4 MIME-Version: 1.0 To: Oleg Nesterov CC: Ingo Molnar , lkml , Roland McGrath , Jason Baron , systemtap , DLE Subject: Re: [PATCH -tip v3 0/3] tracepoint: Add signal events References: <20091120213108.14708.97871.stgit@dhcp-100-2-132.bos.redhat.com> <20091123175740.GA15594@elte.hu> <20091124212247.GA11773@redhat.com> In-Reply-To: <20091124212247.GA11773@redhat.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-IsSubscribed: yes Mailing-List: contact systemtap-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Post: List-Help: , Sender: systemtap-owner@sourceware.org X-SW-Source: 2009-q4/txt/msg00687.txt.bz2 Oleg Nesterov wrote: > On 11/23, Ingo Molnar wrote: >> >> * Masami Hiramatsu wrote: >> >>> Hi, >>> >>> These patches add signal related tracepoints including >>> signal generation, delivery, and loss. First patch also >>> moves signal-sending tracepoint from events/sched.h to >>> events/signal.h. >>> >>> Changes in v3 >>> - Add Docbook style comments >>> >>> Changes in v2 >>> - Add siginfo arguments >>> >>> Thank you, >>> >>> --- >>> >>> Masami Hiramatsu (3): >>> tracepoint: Add signal loss events >>> tracepoint: Add signal deliver event >>> tracepoint: Move signal sending tracepoint to events/signal.h >>> >>> >>> Documentation/DocBook/tracepoint.tmpl | 5 + >>> include/trace/events/sched.h | 25 ----- >>> include/trace/events/signal.h | 173 +++++++++++++++++++++++++++++++++ >>> kernel/signal.c | 27 ++++- >>> 4 files changed, 198 insertions(+), 32 deletions(-) >>> create mode 100644 include/trace/events/signal.h >> >> Would be nice to have Roland's and Oleg's Acked-by tags in the patches - >> to show that this is a representative and useful looking set of signal >> events. > > Sorry, I can't really comment these patches. > > I mean, I do not know which info is useful and which is not. > For example, I am a bit surprized we report trace_signal_lose_info() > but please do not consider this as if I think we shouldn't. Just I > do not know. > > OTOH, we do not report if __send_signal() fails just because the > legacy signal is already queued. We do not report who sends the signal, > we do not report if it was private or shared. zap_process, complete_signal > can "send" SIGKILL via sigaddset, this won't be noticed. But again, it is > not that I think this should be reported. > > In short: I think any info may be useful, and these patches can help. > But I do not understand what exactly should be reported to userspace. Yeah, any comments are welcome:-) IMHO, these tracepoints are just for providing options for users who care about who sent the signal, etc. Thank you, -- Masami Hiramatsu Software Engineer Hitachi Computer Products (America), Inc. Software Solutions Division e-mail: mhiramat@redhat.com