From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 8217 invoked by alias); 28 Nov 2009 16:11:47 -0000 Received: (qmail 8199 invoked by uid 22791); 28 Nov 2009 16:11:44 -0000 X-SWARE-Spam-Status: No, hits=-2.5 required=5.0 tests=AWL,BAYES_00,SPF_HELO_PASS,SPF_PASS X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Sat, 28 Nov 2009 16:11:37 +0000 Received: from int-mx02.intmail.prod.int.phx2.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id nASGBa4u030777 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Sat, 28 Nov 2009 11:11:36 -0500 Received: from [10.11.10.52] (vpn-10-52.rdu.redhat.com [10.11.10.52]) by int-mx02.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id nASGBXhE015181; Sat, 28 Nov 2009 11:11:33 -0500 Message-ID: <4B114BB4.6080307@redhat.com> Date: Sat, 28 Nov 2009 16:11:00 -0000 From: Masami Hiramatsu User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9.1.4pre) Gecko/20091014 Fedora/3.0-2.8.b4.fc11 Thunderbird/3.0b4 MIME-Version: 1.0 To: "Eric W. Biederman" CC: Frederic Weisbecker , Ingo Molnar , Ananth N Mavinakayanahalli , lkml , systemtap , DLE , Jim Keniston , Srikar Dronamraju , Christoph Hellwig , Steven Rostedt , "H. Peter Anvin" , Anders Kaseorg , Tim Abbott , Andi Kleen , Jason Baron , Mathieu Desnoyers Subject: Re: [PATCH -tip v6 04/11] kprobes: Jump optimization sysctl interface References: <20091125165510.6073.48721.stgit@harusame> <20091125165541.6073.43956.stgit@harusame> In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-IsSubscribed: yes Mailing-List: contact systemtap-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Post: List-Help: , Sender: systemtap-owner@sourceware.org X-SW-Source: 2009-q4/txt/msg00731.txt.bz2 Eric W. Biederman wrote: > Masami Hiramatsu writes: > >> Add /proc/sys/debug/kprobes-optimization sysctl which enables and disables >> kprobes jump optimization on the fly for debugging. >> >> Changes in v6: >> - Update comments and coding style. >> > > This will break when it hits the linux-next. As ctl_name has been > removed in the sysctl tree. Not setting ctl_name is equivalent > to setting ctl_name = CTL_UNNUMBERED. It is 0 in both cases. > So you can safely drop touches of ctl_name. > > Ideally you would also call register_sysctl_paths from kernel/kprobes.c > and not add to the ifdef horror that is kernel/sysctl.c but that > is probably more trouble than it is worth right now. One way or > another there is going to be at least a minor conflict when this code > merges with the sysctl tree. Thanks for telling me! OK, so I'll remove that line. Thank you, >> #include >> #include >> @@ -1621,6 +1622,18 @@ static struct ctl_table debug_table[] = { >> .proc_handler = proc_dointvec >> }, >> #endif >> +#if defined(CONFIG_OPTPROBES) >> + { >> + .ctl_name = CTL_UNNUMBERED, > ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ Please remove this line. >> + .procname = "kprobes-optimization", >> + .data =&sysctl_kprobes_optimization, >> + .maxlen = sizeof(int), >> + .mode = 0644, >> + .proc_handler = proc_kprobes_optimization_handler, >> + .extra1 =&zero, >> + .extra2 =&one, >> + }, >> +#endif >> { .ctl_name = 0 } >> }; > > > Eric > -- > To unsubscribe from this list: send the line "unsubscribe linux-kernel" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html > Please read the FAQ at http://www.tux.org/lkml/ -- Masami Hiramatsu Software Engineer Hitachi Computer Products (America), Inc. Software Solutions Division e-mail: mhiramat@redhat.com