From: Masami Hiramatsu <mhiramat@redhat.com>
To: KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>
Cc: Ingo Molnar <mingo@elte.hu>,
Andrew Morton <akpm@linux-foundation.org>,
lkml <linux-kernel@vger.kernel.org>,
systemtap <systemtap@sources.redhat.com>,
DLE <dle-develop@lists.sourceforge.net>,
Oleg Nesterov <oleg@redhat.com>,
Roland McGrath <roland@redhat.com>,
Jason Baron <jbaron@redhat.com>
Subject: Re: [PATCH v3] [RFC] tracepoint: Add signal coredump tracepoint
Date: Wed, 09 Dec 2009 16:16:00 -0000 [thread overview]
Message-ID: <4B1FCD74.8020302@redhat.com> (raw)
In-Reply-To: <4B1FCB54.6000105@redhat.com>
Masami Hiramatsu wrote:
>
>
> KOSAKI Motohiro wrote:
>>> + TP_fast_assign(
>>> + __entry->sig = (int)cprm->signr;
>>> + __entry->limit = cprm->limit;
>>> + __entry->flags = cprm->mm_flags;
>>> + __entry->retval = retval;
>>> + __assign_str(name, core_name);
>>> + ),
>>> +
>>> + TP_printk("sig=%d limit=%lu dumpable=0x%lx dump_filter=0x%lx "
>>> + "corename=\"%s\" retval=%d",
>>> + __entry->sig, __entry->limit,
>>> + __entry->flags& MMF_DUMPABLE_MASK,
>>> + (__entry->flags& MMF_DUMP_FILTER_MASK)>>
>>> + MMF_DUMP_FILTER_SHIFT,
>>> + __get_str(name), __entry->retval)
>>> +);
>>> #endif /* _TRACE_SIGNAL_H */
>>
>> I don't think "limit" is userfriendly name, core_limit or core_size_limit is better?
>> plus, we have core_pipe_limit sysctl too. (it's similar but different concept limit).
>
> Ah, I missed it. OK, so I'll rename core_limit and add core_pipe_limit.
Hmm, perhaps, would we need a pair of core_pipe_limit and dump_count?
because it limits the number of concurrently dump-to-pipe and the number
is stored on dump_count.
Or, maybe it is enough to trace current parameters, because if we hit the
core_pipe_limit, we can see -EFBIG at retval parameter.
> Thank you for pointed it out :-)
>
>>
>> other parts looks good to me.
>>
>>
>>
>
> Thanks!
>
--
Masami Hiramatsu
Software Engineer
Hitachi Computer Products (America), Inc.
Software Solutions Division
e-mail: mhiramat@redhat.com
next prev parent reply other threads:[~2009-12-09 16:16 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <4B128ECF.9020906@redhat.com>
2009-12-02 20:42 ` [PATCH v2] " Masami Hiramatsu
2009-12-03 10:40 ` Ingo Molnar
2009-12-03 11:30 ` Masami Hiramatsu
2009-12-05 7:17 ` Ingo Molnar
2009-12-07 17:19 ` Masami Hiramatsu
2009-12-05 7:18 ` KOSAKI Motohiro
2009-12-07 15:25 ` Masami Hiramatsu
2009-12-08 1:51 ` KOSAKI Motohiro
2009-12-08 20:35 ` [PATCH v3] " Masami Hiramatsu
2009-12-09 5:34 ` KOSAKI Motohiro
2009-12-09 16:07 ` Masami Hiramatsu
2009-12-09 16:16 ` Masami Hiramatsu [this message]
2009-12-09 20:34 ` [PATCH v4] " Masami Hiramatsu
2009-12-10 0:09 ` KOSAKI Motohiro
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4B1FCD74.8020302@redhat.com \
--to=mhiramat@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=dle-develop@lists.sourceforge.net \
--cc=jbaron@redhat.com \
--cc=kosaki.motohiro@jp.fujitsu.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=oleg@redhat.com \
--cc=roland@redhat.com \
--cc=systemtap@sources.redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).