From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 10456 invoked by alias); 26 Feb 2010 20:30:11 -0000 Received: (qmail 10254 invoked by uid 22791); 26 Feb 2010 20:30:09 -0000 X-SWARE-Spam-Status: No, hits=-6.6 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_HI,SPF_HELO_PASS X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Fri, 26 Feb 2010 20:30:04 +0000 Received: from int-mx04.intmail.prod.int.phx2.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.17]) by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id o1QKU2W5019958 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Fri, 26 Feb 2010 15:30:03 -0500 Received: from localhost.localdomain (vpn-8-184.rdu.redhat.com [10.11.8.184]) by int-mx04.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id o1QKU1pQ004649 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Fri, 26 Feb 2010 15:30:02 -0500 Message-ID: <4B882F48.3000509@redhat.com> Date: Fri, 26 Feb 2010 20:30:00 -0000 From: David Smith User-Agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.1.7) Gecko/20100120 Fedora/3.0.1-1.fc12 Lightning/1.0b2pre Thunderbird/3.0.1 MIME-Version: 1.0 To: Steve Dickson CC: Systemtap Mailing list Subject: Re: [PATCH 04/10] Updated nfsd.proc.write probes References: <4B86F6E4.8020408@RedHat.com> <4B86F814.4060209@RedHat.com> In-Reply-To: <4B86F814.4060209@RedHat.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit X-IsSubscribed: yes Mailing-List: contact systemtap-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Post: List-Help: , Sender: systemtap-owner@sourceware.org X-SW-Source: 2010-q1/txt/msg00543.txt.bz2 On 02/25/2010 04:22 PM, Steve Dickson wrote: > commit 1a3da2a334dc24b2efb1d7f165fe81af2261524f > Author: Steve Dickson > Date: Tue Feb 23 11:48:15 2010 -0500 > > Updated nfsd.proc.write probes > > Converted the nfsd.proc.write probes to used > the @cast() mechanism. > > Created the nfsd.proc4.write probes > > Signed-off-by: Steve Dickson > > diff --git a/tapset/nfsd.stp b/tapset/nfsd.stp > index 84f1c56..b501773 100644 > --- a/tapset/nfsd.stp > +++ b/tapset/nfsd.stp ... reasonable looking changes deleted ... > +probe nfsd.proc4.commit = kernel.function("nfsd4_commit") !, > + module("nfsd").function("nfsd4_commit") ? > +{ > + client_ip = addr_from_rqst($rqstp) > + proto = $rqstp->rq_prot > + version = 4 > + fh = & @cast($cstate, "nfsd4_compound_state", "kernel:nfsd")->current_fh > + count = $commit->co_offset > + offset = $commit->co_offset Is setting both 'count' and 'offset' from the same value correct? -- David Smith dsmith@redhat.com Red Hat http://www.redhat.com 256.217.0141 (direct) 256.837.0057 (fax)