Compilation failed on pfiles tool

Compilation failed on pfiles tool

[LiuChenhong]

Hi, everyone,
     I downloaded pfiles tool from
http://sources.redhat.com/systemtap/wiki/WSPfiles , but I can't run
the script, it came up with compilation failed.
I revised the line "stap -x $pid -g -u -e" to "stap -x $pid -gkvv -u
-e" and messages are as follows:

~/programming/systemtap sudo ./pfiles `pgrep pidgin`
SystemTap translator/driver (version 0.9.8/0.141 non-git sources)
Copyright (C) 2005-2009 Red Hat, Inc. and others
This is free software; see the source for copying conditions.
Session arch: i686 release: 2.6.31-20-generic
Created temporary directory "/tmp/stapGCWfNy"
Searched '/usr/share/systemtap/tapset/
i686/*.stp', found 3
Searched '/usr/share/systemtap/tapset/*.stp', found 51
Pass 1: parsed user script and 54 library script(s) in 500usr/10sys/524real ms.
Pass 2: analyzed script: 1 probe(s), 192 function(s), 17 embed(s), 0
global(s) in 290usr/320sys/596real ms.
Pass 3: translated to C into "/tmp/stapGCWfNy/stap_9037.c" in
30usr/0sys/32real ms.
Running make -C "/lib/modules/2.6.31-20-generic/build"
M="/tmp/stapGCWfNy" modules >/dev/null
/tmp/stapGCWfNy/stap_9037.c: In function ‘function_socket_ipv6_peername’:
/tmp/stapGCWfNy/stap_9037.c:15382: error: expected ‘)’ before ‘NIP6_FMT’
/tmp/stapGCWfNy/stap_9037.c: In function ‘function_socket_ipv6_sockname’:
/tmp/stapGCWfNy/stap_9037.c:15424: error: expected ‘)’ before ‘NIP6_FMT’
make[1]: *** [/tmp/stapGCWfNy/stap_9037.o] error 1
make: *** [_module_/tmp/stapGCWfNy] error 2
Error 2 No such file or directory
Pass 4: compiled C into "stap_9037.ko" in 4810usr/820sys/5778real ms.
Pass 4: compilation failed.  Try again with another '--vp 0001' option.
Keeping temporary directory "/tmp/stapGCWfNy"


So, can what's the problem?

Re: Compilation failed on pfiles tool

[David Smith]

(once again, this time to the list as well)

On 03/26/2010 01:37 AM, LiuChenhong wrote:
> Hi, everyone,
>      I downloaded pfiles tool from
> http://sources.redhat.com/systemtap/wiki/WSPfiles , but I can't run
> the script, it came up with compilation failed.
> I revised the line "stap -x $pid -g -u -e" to "stap -x $pid -gkvv -u
> -e" and messages are as follows:
...
> /tmp/stapGCWfNy/stap_9037.c: In function ‘function_socket_ipv6_peername’:
> /tmp/stapGCWfNy/stap_9037.c:15382: error: expected ‘)’ before ‘NIP6_FMT’
> /tmp/stapGCWfNy/stap_9037.c: In function ‘function_socket_ipv6_sockname’:
> /tmp/stapGCWfNy/stap_9037.c:15424: error: expected ‘)’ before ‘NIP6_FMT’

Looks like this kernel commit removed the NIP6_FMT/NIP6 macros:

<http://git.kernel.org/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commit;h=b189db5d299c6824780af5590564ff608adb3dea>

Eugene, got any thoughts on the best way to fix this?

-- 
David Smith
dsmith@redhat.com
Red Hat
http://www.redhat.com
256.217.0141 (direct)
256.837.0057 (fax)

Re: Compilation failed on pfiles tool

[Frank Ch. Eigler]

David Smith <dsmith@redhat.com> writes:

> Looks like this kernel commit removed the NIP6_FMT/NIP6 macros:
>
> <http://git.kernel.org/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commit;h=b189db5d299c6824780af5590564ff608adb3dea>
>
> Eugene, got any thoughts on the best way to fix this?

The copy of pfiles in the source code's examples corrects for this.
The warstory page should be updated to link to it.

- FChE

Re: Compilation failed on pfiles tool

[Eugene Teo]

Hi Chenhong,

On 03/26/2010 11:20 PM, Frank Ch. Eigler wrote:
> David Smith<dsmith@redhat.com>  writes:
>
>> Looks like this kernel commit removed the NIP6_FMT/NIP6 macros:
>>
>> <http://git.kernel.org/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commit;h=b189db5d299c6824780af5590564ff608adb3dea>
>>
>> Eugene, got any thoughts on the best way to fix this?
>
> The copy of pfiles in the source code's examples corrects for this.
> The warstory page should be updated to link to it.

The pfiles script has been committed in the upstream systemtap repo. You 
can either download the script from http://goo.gl/s4bF or run it from 
./testsuite/systemtap.examples/process/pfiles.stp.

I have updated the wiki with the correct link to it.

Let us know if it worked for you.

Thanks, Eugene

Re: Compilation failed on pfiles tool

[Eugene Teo]

On 03/29/2010 12:19 PM, Neo Liu wrote:
> Hi, Eugene,
>      I already tried the pfiles.stp in the systemtap' testsuit, it works fine.
>
> Thanks!

Good to hear ;)

Eugene

> On Mon, Mar 29, 2010 at 8:28 AM, Eugene Teo<eteo@redhat.com>  wrote:
>> Hi Chenhong,
>>
>> On 03/26/2010 11:20 PM, Frank Ch. Eigler wrote:
>>
>> The pfiles script has been committed in the upstream systemtap repo. You can
>> either download the script from http://goo.gl/s4bF or run it from
>> ./testsuite/systemtap.examples/process/pfiles.stp.
>>
>> I have updated the wiki with the correct link to it.
>>
>> Let us know if it worked for you.
>>
>> Thanks, Eugene
>>


-- 
Eugene Teo / Red Hat Security Response Team