From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 29416 invoked by alias); 26 Apr 2010 19:10:48 -0000 Received: (qmail 29405 invoked by uid 22791); 26 Apr 2010 19:10:47 -0000 X-SWARE-Spam-Status: No, hits=-6.9 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_HI,SPF_HELO_PASS,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Mon, 26 Apr 2010 19:10:40 +0000 Received: from int-mx05.intmail.prod.int.phx2.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.18]) by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id o3QJAcn9028932 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Mon, 26 Apr 2010 15:10:39 -0400 Received: from [10.16.2.46] (dhcp-100-2-46.bos.redhat.com [10.16.2.46]) by int-mx05.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id o3QJAbW1003274; Mon, 26 Apr 2010 15:10:37 -0400 Message-ID: <4BD5E52D.502@redhat.com> Date: Tue, 27 Apr 2010 23:38:00 -0000 From: Masami Hiramatsu User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9.1.9) Gecko/20100330 Fedora/3.0.4-1.fc11 Thunderbird/3.0.4 MIME-Version: 1.0 To: Arnaldo Carvalho de Melo CC: Ingo Molnar , lkml , Paul Mackerras , Peter Zijlstra , Mike Galbraith , Frederic Weisbecker , systemtap , DLE Subject: Re: [PATCH -tip 2/4] perf probe: Fix to use symtab only if no debuginfo References: <20100421195616.24664.89980.stgit@localhost6.localdomain6> <20100421195624.24664.46214.stgit@localhost6.localdomain6> <20100426124815.GD7460@ghostprotocols.net> <4BD5E298.4020506@redhat.com> <20100426190806.GA8565@ghostprotocols.net> In-Reply-To: <20100426190806.GA8565@ghostprotocols.net> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit X-IsSubscribed: yes Mailing-List: contact systemtap-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Post: List-Help: , Sender: systemtap-owner@sourceware.org X-SW-Source: 2010-q2/txt/msg00215.txt.bz2 Arnaldo Carvalho de Melo wrote: > Em Mon, Apr 26, 2010 at 02:59:36PM -0400, Masami Hiramatsu escreveu: >> Arnaldo Carvalho de Melo wrote: >>> Em Wed, Apr 21, 2010 at 03:56:24PM -0400, Masami Hiramatsu escreveu: >>>> Fix perf probe to use symtab only if there is no debuginfo, >>>> because debuginfo has more precise information than symtab. >>> >>> "more precise"? Wouldn't it be "more expressive", i.e. with more >>> information (parameter list with types, return type, location of >>> parameters, etc), because what is common to both have the same value, >>> i.e. the function address and size. >> >> Indeed. debuginfo has just more information than symtab, but >> symtab certainly provides precise information for symbol-address. > > I applied the patch, just replaced "more precise information" with "more > information". Thank you very much! :) > > - Arnaldo > -- > To unsubscribe from this list: send the line "unsubscribe linux-kernel" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html > Please read the FAQ at http://www.tux.org/lkml/ -- Masami Hiramatsu e-mail: mhiramat@redhat.com