From: Masami Hiramatsu <mhiramat@redhat.com>
To: ananth@in.ibm.com
Cc: Ingo Molnar <mingo@elte.hu>, lkml <linux-kernel@vger.kernel.org>,
systemtap <systemtap@sources.redhat.com>,
DLE <dle-develop@lists.sourceforge.net>,
Jim Keniston <jkenisto@us.ibm.com>,
Jason Baron <jbaron@redhat.com>,
Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Subject: Re: [PATCH -tip v2 1/5] [BUGFIX] kprobes: Fix selftest to clear flags field for reusing probes
Date: Wed, 19 May 2010 19:52:00 -0000 [thread overview]
Message-ID: <4BF41501.1020909@redhat.com> (raw)
In-Reply-To: <20100519050246.GB17114@in.ibm.com>
Ananth N Mavinakayanahalli wrote:
> On Tue, May 18, 2010 at 04:12:51PM -0400, Masami Hiramatsu wrote:
>
>> kernel/test_kprobes.c | 12 +++++++++---
>> 1 files changed, 9 insertions(+), 3 deletions(-)
>>
>> diff --git a/kernel/test_kprobes.c b/kernel/test_kprobes.c
>> index 4f10451..ede20f4 100644
>> --- a/kernel/test_kprobes.c
>> +++ b/kernel/test_kprobes.c
>> @@ -115,7 +115,9 @@ static int test_kprobes(void)
>> int ret;
>> struct kprobe *kps[2] = {&kp, &kp2};
>>
>> - kp.addr = 0; /* addr should be cleard for reusing kprobe. */
>> + /* addr and flags should be cleard for reusing kprobe. */
>> + kp.addr = 0;
>
> kp.addr = NULL;
OK, I'll fix that (and below too).
Thank you!
>
>> + kp.flags = 0;
>> ret = register_kprobes(kps, 2);
>> if (ret < 0) {
>> printk(KERN_ERR "Kprobe smoke test failed: "
>> @@ -210,7 +212,9 @@ static int test_jprobes(void)
>> int ret;
>> struct jprobe *jps[2] = {&jp, &jp2};
>>
>> - jp.kp.addr = 0; /* addr should be cleard for reusing kprobe. */
>> + /* addr and flags should be cleard for reusing kprobe. */
>> + jp.kp.addr = 0;
>
> Same here...
>
>> + jp.kp.flags = 0;
>> ret = register_jprobes(jps, 2);
>> if (ret < 0) {
>> printk(KERN_ERR "Kprobe smoke test failed: "
>> @@ -323,7 +327,9 @@ static int test_kretprobes(void)
>> int ret;
>> struct kretprobe *rps[2] = {&rp, &rp2};
>>
>> - rp.kp.addr = 0; /* addr should be cleard for reusing kprobe. */
>> + /* addr and flags should be cleard for reusing kprobe. */
>> + rp.kp.addr = 0;
>
> Here too.
>
> Ananth
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at http://www.tux.org/lkml/
--
Masami Hiramatsu
e-mail: mhiramat@redhat.com
next prev parent reply other threads:[~2010-05-19 16:56 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-05-18 20:08 [PATCH -tip v2 0/5] kprobes: batch (un)optimization support Masami Hiramatsu
2010-05-18 20:29 ` [PATCH -tip v2 1/5] [BUGFIX] kprobes: Fix selftest to clear flags field for reusing probes Masami Hiramatsu
2010-05-19 16:47 ` Ananth N Mavinakayanahalli
2010-05-19 19:52 ` Masami Hiramatsu [this message]
2010-05-19 5:03 ` [PATCH -tip v2 2/5] [CLEANUP] kprobes: Remove redundant text_mutex lock in optimize Masami Hiramatsu
2010-05-19 14:10 ` [PATCH -tip v2 4/5] kprobes/x86: Use text_poke_smp_batch Masami Hiramatsu
2010-05-19 14:10 ` [PATCH -tip v2 3/5] x86: Introduce text_poke_smp_batch() for batch-code modifying Masami Hiramatsu
2010-05-19 14:11 ` [PATCH -tip v2 5/5] kprobes: Support delayed unoptimization Masami Hiramatsu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4BF41501.1020909@redhat.com \
--to=mhiramat@redhat.com \
--cc=ananth@in.ibm.com \
--cc=dle-develop@lists.sourceforge.net \
--cc=jbaron@redhat.com \
--cc=jkenisto@us.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mathieu.desnoyers@efficios.com \
--cc=mingo@elte.hu \
--cc=systemtap@sources.redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).