public inbox for systemtap@sourceware.org
 help / color / mirror / Atom feed
* Re: [PATCHv10 2.6.35-rc6-tip 9/14]  trace: uprobes trace_event interface
       [not found]             ` <20100802080032.GA12078@infradead.org>
@ 2010-08-02  9:29               ` Masami Hiramatsu
  0 siblings, 0 replies; only message in thread
From: Masami Hiramatsu @ 2010-08-02  9:29 UTC (permalink / raw)
  To: Christoph Hellwig
  Cc: Ingo Molnar, Frederic Weisbecker, Srikar Dronamraju,
	Peter Zijlstra, Steven Rostedt, Randy Dunlap,
	Arnaldo Carvalho de Melo, Linus Torvalds, Oleg Nesterov,
	Mark Wielaard, Mathieu Desnoyers, Andrew Morton, Naren A Devaiah,
	Jim Keniston, Frank Ch. Eigler, Ananth N Mavinakayanahalli, LKML,
	Paul E. McKenney, 2nddept-manager, SystemTAP

Christoph Hellwig wrote:
> On Mon, Aug 02, 2010 at 09:56:37AM +0200, Ingo Molnar wrote:
>>>> Hmm, I disagree with it, because both Kprobes and Uprobes provides
>>>> APIs for modules too.
>>> I'm not sure there is a point in maintaining a leightweight version for out 
>>> of tree code. These modules could just select kprobes/uprobes events as 
>>> well.
>>>
>>> As you prefer, that was just a suggestion to make it more simple.
>> The upstream policy always was that out of tree code does not exist as far as 
>> the kernel is concerned. So it is wrong to make the kernel crappier while 
>> helping out of tree code.
> 
> Indeed.  In addition to that the current version of uprobes does not
> actually have any exported symbols.

Ah, indeed. :-(

And then, it conflicts with the description about uprobes in
Documentation/uprobes.txt:

> +Uprobes-based instrumentation can be packaged as a kernel
> +module.  In the simplest case, the module's init function installs
> +("registers") one or more probes, and the exit function unregisters
> +them.

So, that could be a bug.

Anyway, at least kprobes has some sample modules under samples/kprobes/.
Aren't they in-tree consumers of kprobes?

Thank you,

-- 
Masami HIRAMATSU
2nd Research Dept.
Hitachi, Ltd., Systems Development Laboratory
E-mail: masami.hiramatsu.pt@hitachi.com

^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2010-08-02  9:29 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
     [not found] <20100727110855.24690.26901.sendpatchset@localhost6.localdomain6>
     [not found] ` <20100727111045.24690.31897.sendpatchset@localhost6.localdomain6>
     [not found]   ` <4C510BCE.4010704@hitachi.com>
     [not found]     ` <20100802022055.GB5581@nowhere>
     [not found]       ` <4C563F44.9080300@hitachi.com>
     [not found]         ` <20100802074619.GA5292@nowhere>
     [not found]           ` <20100802075637.GB24085@elte.hu>
     [not found]             ` <20100802080032.GA12078@infradead.org>
2010-08-02  9:29               ` [PATCHv10 2.6.35-rc6-tip 9/14] trace: uprobes trace_event interface Masami Hiramatsu

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).