* sdt_types.c
@ 2010-11-12 0:09 Roland McGrath
2010-11-12 22:26 ` sdt_types.c Stan Cox
0 siblings, 1 reply; 2+ messages in thread
From: Roland McGrath @ 2010-11-12 0:09 UTC (permalink / raw)
To: systemtap
To test the case that's hard, you need to use an argument of "array", not
"&array". This file should test that. It's not particularly useful to
test "&array" also, since that is just a pointer type, and those are
already tested.
To be thoroughly useful about covering lots of types, this file should be
compiled with a variety of -ansi/-pedantic/-std=foo options.
It would be useful to cover C++ too. That could be done just by including
-xc++ in the set of options to permute through. The C99 initializers would
need to be replaced with plain ordered initializer lists to compile in C++,
or with -ansi/-std=c89.
It would also be useful to have some cases in there that use a string
constant as the argument. It could also use some cases that distinguish
whether the signedness handling is doing the right thing for various sizes
of integral type.
Thanks,
Roland
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: sdt_types.c
2010-11-12 0:09 sdt_types.c Roland McGrath
@ 2010-11-12 22:26 ` Stan Cox
0 siblings, 0 replies; 2+ messages in thread
From: Stan Cox @ 2010-11-12 22:26 UTC (permalink / raw)
To: systemtap
Good suggestions, I'll add tests for all of those. I have added user_int16
(user_short), user_uint16, user_int32 (user_int), user_uint32, and user_int64
to conversions.stp.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2010-11-12 22:26 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2010-11-12 0:09 sdt_types.c Roland McGrath
2010-11-12 22:26 ` sdt_types.c Stan Cox
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).