From: Josh Stone <jistone@redhat.com>
To: Jake Maul <jakemaul@gmail.com>
Cc: William Cohen <wcohen@redhat.com>, systemtap@sourceware.org
Subject: Re: Linux VFS cache hit rate script
Date: Fri, 22 Apr 2011 20:28:00 -0000 [thread overview]
Message-ID: <4DB1E4D2.70200@redhat.com> (raw)
In-Reply-To: <BANLkTinkcC2Hub_dRe1-vVhW79omG+w3AA@mail.gmail.com>
On 04/22/2011 12:16 PM, Jake Maul wrote:
> No problem... seems to have no effect though:
>
> 339869 dev: 16 devname: N/A
> 345 dev: 18 devname: N/A
> 4569 dev: 22 devname: N/A
> 5 dev: 23 devname: N/A
> 798 dev: 265289728 devname: dm-0
> 640 dev: 3 devname: N/A
> 2594 dev: 5 devname: N/A
> 250861 dev: 6 devname: N/A
>
> I just commented out the existing version in
> /usr/share/systemtap/tapsets/vfs.stp, and put your function in
> instead. Do I need to do anything more than that, like rebuild
> something? (not a systemtap dev)
That should do it. I should have been more clear - the effect I
intended was just to relieve the need for MAXMAPENTRIES. The
"__devnames" map should now only contain the real device names, and not
waste any time/space on "N/A" entries. Your script's output would not
be affected though.
Josh
next prev parent reply other threads:[~2011-04-22 20:28 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-04-20 19:04 Jake Maul
2011-04-20 20:09 ` William Cohen
2011-04-20 20:46 ` Jake Maul
2011-04-20 20:57 ` Josh Stone
2011-04-20 22:25 ` Jake Maul
2011-04-21 20:17 ` Jake Maul
2011-04-21 22:31 ` William Cohen
2011-04-21 23:02 ` Jake Maul
2011-04-21 23:46 ` Josh Stone
2011-04-22 19:17 ` Jake Maul
2011-04-22 20:28 ` Josh Stone [this message]
2011-04-22 21:47 ` Jake Maul
2011-04-25 21:54 ` Josh Stone
2011-04-26 2:11 ` Jake Maul
2011-04-25 22:53 ` Josh Stone
2011-04-26 1:59 ` Jake Maul
2011-04-26 2:44 ` Josh Stone
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4DB1E4D2.70200@redhat.com \
--to=jistone@redhat.com \
--cc=jakemaul@gmail.com \
--cc=systemtap@sourceware.org \
--cc=wcohen@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).