From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 17228 invoked by alias); 22 Apr 2011 20:28:19 -0000 Received: (qmail 17221 invoked by uid 22791); 22 Apr 2011 20:28:18 -0000 X-SWARE-Spam-Status: No, hits=-6.1 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_HI,SPF_HELO_PASS,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Fri, 22 Apr 2011 20:28:04 +0000 Received: from int-mx12.intmail.prod.int.phx2.redhat.com (int-mx12.intmail.prod.int.phx2.redhat.com [10.5.11.25]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id p3MKS3jT008168 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Fri, 22 Apr 2011 16:28:03 -0400 Received: from [10.3.113.81] (ovpn-113-81.phx2.redhat.com [10.3.113.81]) by int-mx12.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id p3MKS3BP012811; Fri, 22 Apr 2011 16:28:03 -0400 Message-ID: <4DB1E4D2.70200@redhat.com> Date: Fri, 22 Apr 2011 20:28:00 -0000 From: Josh Stone User-Agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.2.15) Gecko/20110307 Fedora/3.1.9-0.39.b3pre.fc14 Lightning/1.0b3pre Thunderbird/3.1.9 MIME-Version: 1.0 To: Jake Maul CC: William Cohen , systemtap@sourceware.org Subject: Re: Linux VFS cache hit rate script References: <4DAF3D59.7020609@redhat.com> <4DB0B049.8070806@redhat.com> <4DB0C1AD.6080802@redhat.com> In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit X-IsSubscribed: yes Mailing-List: contact systemtap-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Post: List-Help: , Sender: systemtap-owner@sourceware.org X-SW-Source: 2011-q2/txt/msg00149.txt.bz2 On 04/22/2011 12:16 PM, Jake Maul wrote: > No problem... seems to have no effect though: > > 339869 dev: 16 devname: N/A > 345 dev: 18 devname: N/A > 4569 dev: 22 devname: N/A > 5 dev: 23 devname: N/A > 798 dev: 265289728 devname: dm-0 > 640 dev: 3 devname: N/A > 2594 dev: 5 devname: N/A > 250861 dev: 6 devname: N/A > > I just commented out the existing version in > /usr/share/systemtap/tapsets/vfs.stp, and put your function in > instead. Do I need to do anything more than that, like rebuild > something? (not a systemtap dev) That should do it. I should have been more clear - the effect I intended was just to relieve the need for MAXMAPENTRIES. The "__devnames" map should now only contain the real device names, and not waste any time/space on "N/A" entries. Your script's output would not be affected though. Josh