From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 26014 invoked by alias); 5 Dec 2011 16:13:25 -0000 Received: (qmail 26002 invoked by uid 22791); 5 Dec 2011 16:13:23 -0000 X-SWARE-Spam-Status: No, hits=-6.9 required=5.0 tests=AWL,BAYES_00,LOTS_OF_MONEY,RCVD_IN_DNSWL_HI,RP_MATCHES_RCVD,SPF_HELO_PASS X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Mon, 05 Dec 2011 16:13:01 +0000 Received: from int-mx02.intmail.prod.int.phx2.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id pB5GD1Rn001610 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Mon, 5 Dec 2011 11:13:01 -0500 Received: from [10.15.16.135] (dhcp-10-15-16-135.yyz.redhat.com [10.15.16.135]) by int-mx02.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id pB5GD0I6007798 for ; Mon, 5 Dec 2011 11:13:00 -0500 Message-ID: <4EDCED8C.6040908@redhat.com> Date: Mon, 05 Dec 2011 17:38:00 -0000 From: Dave Brolley User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:8.0) Gecko/20111115 Thunderbird/8.0 MIME-Version: 1.0 To: systemtap@sourceware.org Subject: Re: "module privilege check" breaks (cross-)compilation due to libelf dependency References: <28BE1A38672C8B4481BB423D0FD1F22E01BC1426@DNCE03.ent.ti.com> <20111205135825.GF16831@hermans.wildebeest.org> <28BE1A38672C8B4481BB423D0FD1F22E01BC14E6@DNCE03.ent.ti.com> In-Reply-To: <28BE1A38672C8B4481BB423D0FD1F22E01BC14E6@DNCE03.ent.ti.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-IsSubscribed: yes Mailing-List: contact systemtap-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Post: List-Help: , Sender: systemtap-owner@sourceware.org X-SW-Source: 2011-q4/txt/msg00293.txt.bz2 Hi, Sorry for this. I'll re-examine the code to make sure it builds in all environments. Dave On 12/05/2011 09:09 AM, Turgis, Frederic wrote: > Hi, > > After making few times the mistake to not check latest code, I ensure now to be on HEAD of master branch ;-) > > My feeling is that you had an environment with libelf available but elf_getshdrstrndx() not available. > > This is then not sufficient but similar. This solves the issue of unused parameters (this is a warning considered as an error) but not the issue of the use of Elf_Scn type. Systemtap only defines "typedef struct Elf_Scn Elf_Scn;", real definition would come from "elfutils-0.143/libelf/libelfP.h" in my case (but --with-elfutils is not used) > > > > Regards > Fred > > Frederic Turgis > OMAP Platform Business Unit - OMAP System Engineering - Platform Enablement - System Multimedia > > > > Texas Instruments France SA, 821 Avenue Jack Kilby, 06270 Villeneuve Loubet. 036 420 040 R.C.S Antibes. Capital de EUR 753.920 > > -----Original Message----- >> From: Mark Wielaard [mailto:mjw@redhat.com] >> Sent: Monday, December 05, 2011 2:58 PM >> To: Turgis, Frederic >> Cc: SystemTap >> Subject: Re: "module privilege check" breaks >> (cross-)compilation due to libelf dependency >> >> On Mon, Dec 05, 2011 at 01:36:01PM +0000, Turgis, Frederic wrote: >>> Commit "bb4470cacb3f7ce5161f9e8a1b7c37a87516a6c3 PR 13128: Implement >>> module privilege check in staprun." has broken my cross-compilation >>> environment to build "staprun" tool for ARM android (I do 4 first >>> steps on host, staprun step on target), see end of mail. >>> >>> Having a deeper look, there is in fact code in staprun_funcs.c that >>> requires libelf like find_section_in_module() and >>> get_module_required_credentials() (Elf_Scn for example) and that is >>> not surrounded by HAVE_LIBELF_H or HAVE_ELF_GETSHDRSTRNDX >> I had something similar a few days ago, though I don't >> remember exactly which setup it was on. Does the following >> commit help in your case? >> >> commit fa2418539b4ac2cb1352948f68da08890cec7774 >> Author: Mark Wielaard >> Date: Sat Nov 26 02:33:01 2011 +0100 >> >> Fix build error in staprun_funcs.c when >> HAVE_ELF_GETSHDRSTRNDX is not set. >> >> Mark find_section_in_module arguments unused when >> HAVE_ELF_GETSHDRSTRNDX >> isn't set. >> >> Or do you need more than that? >> >> Cheers, >> >> Mark >>