From: David Smith <dsmith@redhat.com>
To: Srikar Dronamraju <srikar@linux.vnet.ibm.com>
Cc: Frank Ch Eigler <fche@redhat.com>, systemtap@sourceware.org
Subject: Re: [Bug uprobes/13539] occasional oops, kernel SEGV, RHEL5, :uprobes:uprobe_free_process+0xba/0x131
Date: Fri, 06 Jan 2012 17:01:00 -0000 [thread overview]
Message-ID: <4F0728BF.6010200@redhat.com> (raw)
In-Reply-To: <20120106122516.GA17178@linux.vnet.ibm.com>
On 01/06/2012 06:25 AM, Srikar Dronamraju wrote:
>
> While I still cannot see a reason how uprobe_{free,put}_process can
> race uprobe_report_{exit,exec}, I certainly think somebit of cleanup
> can be done. However I am dont think we need to do a utask or uproc lookup
> from the table. Especially in case of callbacks.
>
> Mostly similar to what Jim proposed.
> I havent tested this patch myself and I couldnt reproduce the problem.
With your patch, I got the same stapio hang as I mentioned in comment #5
on the bug, but happened on the 3rd run of the unprivileged_myproc.exp
test case (it has happened on every run with the pr13539 branch code for
me). So your code is a slight improvement.
That comment also describes my environment in duplicating the bug which
might help you.
--
David Smith
dsmith@redhat.com
Red Hat
http://www.redhat.com
256.217.0141 (direct)
256.837.0057 (fax)
next prev parent reply other threads:[~2012-01-06 17:01 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-12-21 22:38 [Bug uprobes/13539] New: " fche at redhat dot com
2011-12-21 22:59 ` [Bug uprobes/13539] " fche at redhat dot com
2011-12-22 1:38 ` fche at redhat dot com
2011-12-22 12:20 ` fche at redhat dot com
2011-12-31 14:27 ` fche at redhat dot com
2012-01-02 22:31 ` fche at redhat dot com
2012-01-06 12:25 ` Srikar Dronamraju
2012-01-06 17:01 ` David Smith [this message]
2012-01-06 16:57 ` dsmith at redhat dot com
2012-01-06 17:01 ` dsmith at redhat dot com
2012-01-26 16:10 ` fche at redhat dot com
2012-01-26 22:35 ` dsmith at redhat dot com
2012-01-26 22:58 ` jistone at redhat dot com
2012-01-27 14:52 ` dsmith at redhat dot com
2012-01-27 15:10 ` dsmith at redhat dot com
2012-01-27 16:20 ` jistone at redhat dot com
2012-01-30 22:05 ` fche at redhat dot com
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F0728BF.6010200@redhat.com \
--to=dsmith@redhat.com \
--cc=fche@redhat.com \
--cc=srikar@linux.vnet.ibm.com \
--cc=systemtap@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).