From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 1883 invoked by alias); 5 Jun 2012 19:15:23 -0000 Received: (qmail 1874 invoked by uid 22791); 5 Jun 2012 19:15:22 -0000 X-SWARE-Spam-Status: No, hits=-6.8 required=5.0 tests=AWL,BAYES_00,KHOP_RCVD_UNTRUST,KHOP_THREADED,RCVD_IN_DNSWL_HI,RCVD_IN_HOSTKARMA_W,SPF_HELO_PASS,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 05 Jun 2012 19:15:05 +0000 Received: from int-mx11.intmail.prod.int.phx2.redhat.com (int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id q55JF4CK011396 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Tue, 5 Jun 2012 15:15:04 -0400 Received: from [10.11.10.80] (vpn-10-80.rdu.redhat.com [10.11.10.80]) by int-mx11.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id q55JF46b006753 for ; Tue, 5 Jun 2012 15:15:04 -0400 Message-ID: <4FCE5AB7.2010104@redhat.com> Date: Tue, 05 Jun 2012 19:15:00 -0000 From: Dave Brolley User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:11.0) Gecko/20120329 Thunderbird/11.0.1 MIME-Version: 1.0 To: systemtap@sourceware.org Subject: Re: [PATCH] runtime/staprun/configure.ac: support --without-nss for staprun References: <1338885817-15072-1-git-send-email-schnitzeltony@googlemail.com> <4FCE5517.4070901@redhat.com> In-Reply-To: <4FCE5517.4070901@redhat.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-IsSubscribed: yes Mailing-List: contact systemtap-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Post: List-Help: , Sender: systemtap-owner@sourceware.org X-SW-Source: 2012-q2/txt/msg00208.txt.bz2 Thanks Josh --- you beat me to it. Dave On 06/05/2012 02:51 PM, Josh Stone wrote: > On 06/05/2012 01:43 AM, Andreas Müller wrote: >> Signed-off-by: Andreas Müller >> --- >> runtime/staprun/configure.ac | 20 +++++++++++++++----- >> 1 files changed, 15 insertions(+), 5 deletions(-) > Looks like you copied the exact logic from the root configure script, > which is fine. Committed and pushed, thanks! > > That duplication of configure logic is something that I intend to > address in PR14179, where I'm consolidating them into one. But some of > the other changes I'm making there are more invasive, and I'm holding > them until after our next release. So your patch is still helpful to > get into this coming release. > > Thanks, > Josh