public inbox for systemtap@sourceware.org
 help / color / mirror / Atom feed
From: Jonathan Lebon <jlebon@redhat.com>
To: Stefan Hajnoczi <stefanha@redhat.com>
Cc: systemtap@sourceware.org, fche@redhat.com
Subject: Re: [PATCH v2 0/3] initscript: add support for uprobes scripts
Date: Tue, 02 Sep 2014 15:03:00 -0000	[thread overview]
Message-ID: <506323430.41761582.1409670206483.JavaMail.zimbra@redhat.com> (raw)
In-Reply-To: <20140901121508.GA7855@stefanha-thinkpad.redhat.com>

Hi Stefan,

I'm wondering, could we do without the user needing to
provide the -u option at all and make it completely
transparent instead?

I.e. the initscript could always use the new
--save-uprobes switch, and remember whether uprobes.ko was
built or not so that at runtime, it appropriately appends
-u to the staprun command.

This also works around overriding the '-u' option in the
config file, which could previously be used to enable
unoptimized mode.

The only question is how/where this setting would be
remembered. One way I can think of right now is to simply
touch a blank file in the CACHE_PATH's uprobes directory for
each script that requires it, but maybe there's a more
elegant method.

  reply	other threads:[~2014-09-02 15:03 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-08-11 13:25 Stefan Hajnoczi
2014-08-11 13:25 ` [PATCH v2 2/3] initscript: copy uprobes.ko to cache directory Stefan Hajnoczi
2014-08-11 13:25 ` [PATCH v2 3/3] initscript: allow scripts to load uprobes Stefan Hajnoczi
2014-08-11 13:25 ` [PATCH v2 1/3] stap: add --save-uprobes Stefan Hajnoczi
2014-09-01 12:15 ` [PATCH v2 0/3] initscript: add support for uprobes scripts Stefan Hajnoczi
2014-09-02 15:03   ` Jonathan Lebon [this message]
2014-09-03 12:46     ` Stefan Hajnoczi
2014-09-03 23:01       ` Jonathan Lebon
2014-09-03 23:22         ` Josh Stone
2014-09-03 23:44           ` [PATCH] Remove systemtap_session::built_uprobes Josh Stone
2014-09-04 11:13             ` Stefan Hajnoczi
2014-09-04 15:20             ` Jonathan Lebon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=506323430.41761582.1409670206483.JavaMail.zimbra@redhat.com \
    --to=jlebon@redhat.com \
    --cc=fche@redhat.com \
    --cc=stefanha@redhat.com \
    --cc=systemtap@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).