From: Masami Hiramatsu <masami.hiramatsu.pt@hitachi.com>
To: Namhyung Kim <namhyung@kernel.org>
Cc: Hemant Kumar <hkshaw@linux.vnet.ibm.com>,
linux-kernel@vger.kernel.org, srikar@linux.vnet.ibm.com,
peterz@infradead.org, oleg@redhat.com, mingo@redhat.com,
anton@redhat.com, systemtap@sourceware.org
Subject: Re: [PATCH 1/2] SDT markers listing by perf
Date: Wed, 04 Sep 2013 08:02:00 -0000 [thread overview]
Message-ID: <5226E8F4.5060505@hitachi.com> (raw)
In-Reply-To: <87ioyht7e4.fsf@sejong.aot.lge.com>
(2013/09/04 15:42), Namhyung Kim wrote:
> On Tue, 03 Sep 2013 13:06:55 +0530, Hemant Kumar wrote:
>
> [SNIP]
>
>> diff --git a/tools/perf/builtin-probe.c b/tools/perf/builtin-probe.c
>> index e8a66f9..3d8dcdf 100644
>> --- a/tools/perf/builtin-probe.c
>> +++ b/tools/perf/builtin-probe.c
>> @@ -55,6 +55,7 @@ static struct {
>> bool show_funcs;
>> bool mod_events;
>> bool uprobes;
>> + bool sdt;
>> int nevents;
>> struct perf_probe_event events[MAX_PROBES];
>> struct strlist *dellist;
>> @@ -325,6 +326,8 @@ int cmd_probe(int argc, const char **argv, const char *prefix __maybe_unused)
>> opt_set_filter),
>> OPT_CALLBACK('x', "exec", NULL, "executable|path",
>> "target executable name or path", opt_set_target),
>> + OPT_BOOLEAN('S', "sdt", ¶ms.sdt,
>> + "Show and probe on the SDT markers"),
>
> You need to add it to Documentation/perf-probe.txt too. In addition if
> the --sdt option is only able to work with libelf, it should be wrapped
> into the #ifdef LIBELF_SUPPORT pair.
>
> And I'm not sure that it's a good idea to have two behavior on a single
> option (S) - show and probe (add). Maybe it can be separated into two
> or the S option can be used as a flag with existing --list and --add
> option?
>
Good catch! :)
No, that is really bad idea. All probes must be added by "--add" action.
So we need a new probe syntax for specifying sdt marker.
How about the below syntax?
[EVENT=]%PROVIDER:MARKER [ARG ...]
Of course, this will require to list up all markers with "%" prefix for
continuity.
And since --list option is to list up all existing(defined) probe events,
I think --markers (as like as --funcs) is better for listing it up.
Thank you!
--
Masami HIRAMATSU
IT Management Research Dept. Linux Technology Center
Hitachi, Ltd., Yokohama Research Laboratory
E-mail: masami.hiramatsu.pt@hitachi.com
next prev parent reply other threads:[~2013-09-04 8:02 UTC|newest]
Thread overview: 43+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-03 7:36 [RFC PATCH 0/2] Perf support to SDT markers Hemant Kumar Shaw
2013-09-03 7:37 ` [PATCH 1/2] SDT markers listing by perf Hemant Kumar
2013-09-03 8:19 ` Hemant
2013-09-04 6:43 ` Namhyung Kim
2013-09-04 17:40 ` Hemant
2013-09-04 6:42 ` Namhyung Kim
2013-09-04 8:02 ` Masami Hiramatsu [this message]
2013-09-04 17:59 ` Hemant
2013-09-15 11:28 ` Hemant
2013-09-25 4:37 ` Masami Hiramatsu
2013-09-25 6:04 ` Hemant
2013-09-25 8:45 ` Masami Hiramatsu
2013-09-04 17:38 ` Hemant
2013-09-06 6:38 ` Namhyung Kim
2013-09-06 8:41 ` Hemant
2013-09-04 7:22 ` Masami Hiramatsu
2013-09-04 17:52 ` Hemant
2013-09-03 7:37 ` [PATCH 2/2] Support to perf to probe on SDT markers: Hemant Kumar
2013-09-03 9:14 ` Masami Hiramatsu
2013-09-04 7:00 ` Namhyung Kim
2013-09-04 8:10 ` Masami Hiramatsu
2013-09-04 18:00 ` Hemant
2013-09-04 17:50 ` Hemant
2013-09-03 8:25 ` [RFC PATCH 0/2] Perf support to SDT markers Ingo Molnar
2013-09-03 9:17 ` Masami Hiramatsu
2013-09-03 13:23 ` Hemant
2013-09-03 14:22 ` Ingo Molnar
2013-09-03 15:12 ` Mark Wielaard
2013-09-03 19:24 ` Ingo Molnar
2013-09-03 15:24 ` Hemant
2013-09-04 6:49 ` Namhyung Kim
2013-09-04 8:23 ` Masami Hiramatsu
2013-09-04 8:26 ` Mark Wielaard
2013-09-04 8:39 ` Masami Hiramatsu
2013-09-04 18:08 ` Hemant
2013-09-05 4:59 ` Masami Hiramatsu
2013-09-04 18:12 ` Hemant
2013-09-04 18:52 ` Mark Wielaard
2013-09-04 20:39 ` Hemant
2013-09-04 17:45 ` Hemant
2013-09-04 6:09 ` Namhyung Kim
2013-09-04 17:08 ` Hemant
2013-09-04 23:41 ` Andi Kleen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5226E8F4.5060505@hitachi.com \
--to=masami.hiramatsu.pt@hitachi.com \
--cc=anton@redhat.com \
--cc=hkshaw@linux.vnet.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=namhyung@kernel.org \
--cc=oleg@redhat.com \
--cc=peterz@infradead.org \
--cc=srikar@linux.vnet.ibm.com \
--cc=systemtap@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).