From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 6267 invoked by alias); 20 Oct 2013 07:47:41 -0000 Mailing-List: contact systemtap-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Post: List-Help: , Sender: systemtap-owner@sourceware.org Received: (qmail 6256 invoked by uid 89); 20 Oct 2013 07:47:40 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.2 required=5.0 tests=AWL,BAYES_00,RP_MATCHES_RCVD autolearn=ham version=3.3.2 X-HELO: e23smtp03.au.ibm.com Received: from e23smtp03.au.ibm.com (HELO e23smtp03.au.ibm.com) (202.81.31.145) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-SHA encrypted) ESMTPS; Sun, 20 Oct 2013 07:47:38 +0000 Received: from /spool/local by e23smtp03.au.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Sun, 20 Oct 2013 17:47:34 +1000 Received: from d23dlp01.au.ibm.com (202.81.31.203) by e23smtp03.au.ibm.com (202.81.31.209) with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted; Sun, 20 Oct 2013 17:47:34 +1000 Received: from d23relay03.au.ibm.com (d23relay03.au.ibm.com [9.190.235.21]) by d23dlp01.au.ibm.com (Postfix) with ESMTP id 16A872CE8053 for ; Sun, 20 Oct 2013 18:47:29 +1100 (EST) Received: from d23av01.au.ibm.com (d23av01.au.ibm.com [9.190.234.96]) by d23relay03.au.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id r9K7lEMX5439804 for ; Sun, 20 Oct 2013 18:47:17 +1100 Received: from d23av01.au.ibm.com (localhost [127.0.0.1]) by d23av01.au.ibm.com (8.14.4/8.14.4/NCO v10.0 AVout) with ESMTP id r9K7lP2R025537 for ; Sun, 20 Oct 2013 18:47:26 +1100 Received: from localhost.localdomain ([9.79.182.163]) by d23av01.au.ibm.com (8.14.4/8.14.4/NCO v10.0 AVin) with ESMTP id r9K7lGJ4025461; Sun, 20 Oct 2013 18:47:22 +1100 Message-ID: <52638A84.7000706@linux.vnet.ibm.com> Date: Sun, 20 Oct 2013 07:47:00 -0000 From: Hemant Kumar User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130625 Thunderbird/17.0.7 MIME-Version: 1.0 To: Masami Hiramatsu CC: linux-kernel@vger.kernel.org, srikar@linux.vnet.ibm.com, peterz@infradead.org, oleg@redhat.com, hegdevasant@linux.vnet.ibm.com, mingo@redhat.com, anton@redhat.com, systemtap@sourceware.org, namhyung@kernel.org, aravinda@linux.vnet.ibm.com Subject: Re: [PATCH v3 1/3] SDT markers listing by perf: References: <20131018143714.10452.83494.stgit@hemant-fedora> <20131018144231.10452.65885.stgit@hemant-fedora> <5262A4F6.3000609@hitachi.com> In-Reply-To: <5262A4F6.3000609@hitachi.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-TM-AS-MML: No X-Content-Scanned: Fidelis XPS MAILER x-cbid: 13102007-6102-0000-0000-0000045E4430 X-SW-Source: 2013-q4/txt/msg00078.txt.bz2 Hi Masami, On 10/19/2013 08:57 PM, Masami Hiramatsu wrote: > (2013/10/18 23:44), Hemant Kumar wrote: [...] >> +int show_sdt_notes(const char *target) >> +{ >> + int ret; >> + LIST_HEAD(sdt_notes); >> + >> + ret = get_sdt_note_list(&sdt_notes, target); >> + if (!list_empty(&sdt_notes)) { >> + if (!ret) > Hmm, why don't you check the ret first? And I think the > empty check should be done in display_sdt_note_info() and > cleanup_sdt_note_list() (anyway, since both uses list_for_each*() > it is already done). Okay, will do that. > >> + display_sdt_note_info(&sdt_notes); >> + cleanup_sdt_note_list(&sdt_notes); >> + } >> + return ret; >> +} > Others are good for me. :) Great! thanks for the review. :) -- Thanks Hemant Kumar