From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 20968 invoked by alias); 22 Nov 2013 02:35:58 -0000 Mailing-List: contact systemtap-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Post: List-Help: , Sender: systemtap-owner@sourceware.org Received: (qmail 20957 invoked by uid 89); 22 Nov 2013 02:35:57 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=0.6 required=5.0 tests=AWL,BAYES_50,RDNS_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no version=3.3.2 X-HELO: mail9.hitachi.co.jp Received: from Unknown (HELO mail9.hitachi.co.jp) (133.145.228.44) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 22 Nov 2013 02:35:54 +0000 Received: from mlsv8.hitachi.co.jp (unknown [133.144.234.166]) by mail9.hitachi.co.jp (Postfix) with ESMTP id 4A1A437C83; Fri, 22 Nov 2013 11:35:46 +0900 (JST) Received: from mfilter05.hitachi.co.jp by mlsv8.hitachi.co.jp (8.13.1/8.13.1) id rAM2Zkv2028802; Fri, 22 Nov 2013 11:35:46 +0900 Received: from vshuts04.hitachi.co.jp (vshuts04.hitachi.co.jp [10.201.6.86]) by mfilter05.hitachi.co.jp (Switch-3.3.4/Switch-3.3.4) with ESMTP id rAM2ZiRL003364; Fri, 22 Nov 2013 11:35:45 +0900 Received: from gmml27.itg.hitachi.co.jp (unknown [158.213.165.130]) by vshuts04.hitachi.co.jp (Postfix) with ESMTP id 9C26014003D; Fri, 22 Nov 2013 11:35:44 +0900 (JST) Received: from [10.198.208.126] by gmml27.itg.hitachi.co.jp (AIX5.2/8.11.6p2/8.11.0) id rAM2Zi610260668; Fri, 22 Nov 2013 11:35:44 +0900 Message-ID: <528EC2FF.30301@hitachi.com> Date: Fri, 22 Nov 2013 02:35:00 -0000 From: Masami Hiramatsu User-Agent: Mozilla/5.0 (Windows NT 5.2; rv:13.0) Gecko/20120614 Thunderbird/13.0.1 MIME-Version: 1.0 To: Ingo Molnar Cc: "Frank Ch. Eigler" , linux-arch@vger.kernel.org, Ananth N Mavinakayanahalli , Sandeepa Prabhu , x86@kernel.org, lkml , "Steven Rostedt (Red Hat)" , virtualization@lists.linux-foundation.org, systemtap@sourceware.org, "David S. Miller" Subject: Re: Re: [PATCH -tip v3 00/23] kprobes: introduce NOKPROBE_SYMBOL() and general cleaning of kprobe blacklist References: <20131120042148.15296.88360.stgit@kbuild-fedora.novalocal> <20131120153801.GA9743@gmail.com> <20131120173600.GK8993@redhat.com> <528D6C9F.8050809@hitachi.com> <20131121072938.GA16912@gmail.com> In-Reply-To: <20131121072938.GA16912@gmail.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-IsSubscribed: yes X-SW-Source: 2013-q4/txt/msg00262.txt.bz2 (2013/11/21 16:29), Ingo Molnar wrote: > > * Masami Hiramatsu wrote: > >> (2013/11/21 2:36), Frank Ch. Eigler wrote: > > [ ... ] >>> one needs to resort to something like: >>> >>> # cat /proc/kallsyms | grep ' [tT] ' | while read addr type symbol; do >>> perf probe $symbol >>> done >>> >>> then wait for a few hours for that to finish. Then, or while the loop >>> is still running, run >>> >>> # perf record -e 'probe:*' -aR sleep 1 >>> >>> to take a kernel down. >> >> Um, indeed, current blacklist is not perfect. [...] > > Then it needs to be fixed ASAP! OK, I see. At least the two patches included this series should be fixed. :) And more, I need to test all symbols and drills down. >> [...] As I reported in this series, I've found 2 more patterns. I >> guess there still have some others. >> >> But anyway, I don't think it is good to fix all such bugs in this >> series. > > Fixing these bugs is far more important than any cleanup work. I see. This cleanup started with the bugfixes :) > We can apply the fixes together with your cleanup series to make it > all simpler, but the bug fixing absolutely needs to happen right now. OK, I'll test it first and include the bugfixes in this series. Or should I push the fixes separated? Thank you, -- Masami HIRAMATSU IT Management Research Dept. Linux Technology Center Hitachi, Ltd., Yokohama Research Laboratory E-mail: masami.hiramatsu.pt@hitachi.com