From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 5936 invoked by alias); 1 Dec 2013 02:16:58 -0000 Mailing-List: contact systemtap-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Post: List-Help: , Sender: systemtap-owner@sourceware.org Received: (qmail 5870 invoked by uid 89); 1 Dec 2013 02:16:46 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=0.7 required=5.0 tests=AWL,BAYES_50,RDNS_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no version=3.3.2 X-HELO: mail4.hitachi.co.jp Received: from Unknown (HELO mail4.hitachi.co.jp) (133.145.228.5) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Sun, 01 Dec 2013 02:16:44 +0000 Received: from mlsv2.hitachi.co.jp (unknown [133.144.234.166]) by mail4.hitachi.co.jp (Postfix) with ESMTP id 793B233CC2; Sun, 1 Dec 2013 11:16:36 +0900 (JST) Received: from mfilter04.hitachi.co.jp by mlsv2.hitachi.co.jp (8.13.1/8.13.1) id rB12GaQB003144; Sun, 1 Dec 2013 11:16:36 +0900 Received: from vshuts04.hitachi.co.jp (vshuts04.hitachi.co.jp [10.201.6.86]) by mfilter04.hitachi.co.jp (Switch-3.3.4/Switch-3.3.4) with ESMTP id rB12GYtT021150; Sun, 1 Dec 2013 11:16:35 +0900 Received: from gmml27.itg.hitachi.co.jp (unknown [158.213.165.130]) by vshuts04.hitachi.co.jp (Postfix) with ESMTP id C843614003B; Sun, 1 Dec 2013 11:16:34 +0900 (JST) Received: from [10.198.208.96] by gmml27.itg.hitachi.co.jp (AIX5.2/8.11.6p2/8.11.0) id rB12GYT9564212; Sun, 1 Dec 2013 11:16:34 +0900 Message-ID: <529A9C02.4090909@hitachi.com> Date: Sun, 01 Dec 2013 02:16:00 -0000 From: Masami Hiramatsu User-Agent: Mozilla/5.0 (Windows NT 5.2; rv:13.0) Gecko/20120614 Thunderbird/13.0.1 MIME-Version: 1.0 To: Ingo Molnar Cc: "Frank Ch. Eigler" , linux-arch@vger.kernel.org, Ananth N Mavinakayanahalli , Sandeepa Prabhu , x86@kernel.org, lkml , "Steven Rostedt (Red Hat)" , virtualization@lists.linux-foundation.org, systemtap@sourceware.org, "David S. Miller" Subject: Re: Re: Re: Re: Re: [PATCH -tip v3 00/23] kprobes: introduce NOKPROBE_SYMBOL() and general cleaning of kprobe blacklist References: <20131120042148.15296.88360.stgit@kbuild-fedora.novalocal> <20131120153801.GA9743@gmail.com> <20131120173600.GK8993@redhat.com> <528D6C9F.8050809@hitachi.com> <20131121072938.GA16912@gmail.com> <528EC2FF.30301@hitachi.com> <528F4406.3090309@hitachi.com> <20131127133045.GC18422@gmail.com> <52971E66.9080006@hitachi.com> <20131130134618.GA18768@gmail.com> In-Reply-To: <20131130134618.GA18768@gmail.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-IsSubscribed: yes X-SW-Source: 2013-q4/txt/msg00305.txt.bz2 (2013/11/30 22:46), Ingo Molnar wrote: >>>> Anyway, to fix all of them, I think we need file-based blacklist >>>> especially for assembler symbols. >>> >>> assembler symbols shouldn't be particular hard either, just put them >>> into the noprobes section. >> >> Would you mean .kprobes.text? Hmm, I hope not to use it anymore, but >> yeah, bugfix is more important. Agreed. > > No, why not put the symbol address into the 'blacklist' section, > within the asm file? We fill out exception table entries in .S files > as well, see the _ASM_EXTABLE() macro, it's possible to do all that. Oh! I got it. Thank you for the pointer! :) > > It needs not a CPP macro but an assembly macro. OK, I'll try that. Thanks again, -- Masami HIRAMATSU IT Management Research Dept. Linux Technology Center Hitachi, Ltd., Yokohama Research Laboratory E-mail: masami.hiramatsu.pt@hitachi.com